Skip to content

Commit dbec1fc

Browse files
committed
Use an incrementing lock identifier
1 parent 5ba3f0b commit dbec1fc

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

android/src/main/java/com/reactnativecommunity/webview/RNCWebViewModule.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
import java.util.ArrayList;
3939
import java.util.Arrays;
4040
import java.util.HashMap;
41-
import java.util.Random;
4241
import java.util.concurrent.atomic.AtomicReference;
4342

4443
import static android.app.Activity.RESULT_OK;
@@ -62,14 +61,14 @@ protected enum ShouldOverrideCallbackState {
6261
DO_NOT_OVERRIDE,
6362
}
6463

65-
private final Random randomGenerator = new Random();
64+
private int nextLockIdentifier = 0;
6665
private final HashMap<Integer, AtomicReference<ShouldOverrideCallbackState>> shouldOverrideLocks = new HashMap<>();
6766

6867
public synchronized Pair<Integer, AtomicReference<ShouldOverrideCallbackState>> getNewLock() {
69-
Integer nextRand = randomGenerator.nextInt();
68+
final int lockIdentifier = nextLockIdentifier++;
7069
AtomicReference<ShouldOverrideCallbackState> shouldOverride = new AtomicReference<>(ShouldOverrideCallbackState.UNDECIDED);
71-
shouldOverrideLocks.put(nextRand, shouldOverride);
72-
return new Pair<>(nextRand, shouldOverride);
70+
shouldOverrideLocks.put(lockIdentifier, shouldOverride);
71+
return new Pair<>(lockIdentifier, shouldOverride);
7372
}
7473

7574
@Nullable

0 commit comments

Comments
 (0)