fix: fix type and mark deprecated as no usage for unused xcodeVersion and deprecated idb (#1072)

* fix: fix type and mark deprecated as no usage

* chore: add deprecated for idb stuff as well

* reverr unnecessary change

Author: KazuCocoa

lib/types.ts

@@ -94,6 +94,7 @@ export interface AppleDevice {
   udid: string;
   simctl?: any;
   devicectl?: any;
+  /** @deprecated We'll stop supporting idb */
   idb?: any;
   [key: string]: any;
 }

lib/webdriveragent.js

@@ -35,7 +35,7 @@ export class WebDriverAgent {
   agentPath;
 
   /**
-   * @param {import('appium-xcode').XcodeVersion} xcodeVersion
+   * @param {import('appium-xcode').XcodeVersion | undefined} xcodeVersion @deprecated Will be removed as no actual usage.
    * @param {import('./types').WebDriverAgentArgs} args
    * @param {import('@appium/types').AppiumLogger?} [log=null]
    */
@@ -51,6 +51,7 @@ export class WebDriverAgent {
     this.iosSdkVersion = args.iosSdkVersion;
     this.host = args.host;
     this.isRealDevice = !!args.realDevice;
+    /** @deprecated We'll stop supporting idb */
     this.idb = args.device.idb;
     this.wdaBundlePath = args.wdaBundlePath;
 
@@ -539,6 +540,7 @@ export class WebDriverAgent {
   }
 
   /**
+   * @deprecated We'll stop using idb
    * @returns {Promise<{wdaBundleId: string, testBundleId: string, wdaBundlePath: string}>}
    */
   async prepareWDA () {

lib/xcodebuild.js

@@ -46,7 +46,7 @@ export class XcodeBuild {
   xcodebuild;
 
   /**
-   * @param {import('appium-xcode').XcodeVersion} xcodeVersion
+   * @param {import('appium-xcode').XcodeVersion | undefined} xcodeVersion @deprecated Will be removed as no actual usage.
    * @param {import('./types').AppleDevice} device
    * @param {import('./types').XcodeBuildArgs} args
    * @param {import('@appium/types').AppiumLogger | null} [log=null]