fix: Fix ParseCapabilitiesIfUNIX for macOS/Linux and convert CI to GHA (#991)

Author: KazuCocoa

.github/workflows/unit-test.yml

@@ -0,0 +1,113 @@
+name: Unit Tests
+
+on:
+  push:
+    branches:
+      - main
+      - 'release/**'
+  pull_request:
+    branches:
+      - main
+      - 'release/**'
+
+jobs:
+  test:
+    runs-on: ${{ matrix.os }}
+
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [windows-latest, ubuntu-latest, macos-latest]
+        include:
+          - os: windows-latest
+            framework: 'net48|net8.0'
+          - os: ubuntu-latest
+            framework: 'net8.0'
+          - os: macos-latest
+            framework: 'net8.0'
+
+    env:
+      SOLUTION: 'Appium.Net.sln'
+      BUILD_PLATFORM: 'Any CPU'
+      BUILD_CONFIGURATION: 'Release'
+
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@v4
+
+    - name: Setup .NET
+      uses: actions/setup-dotnet@v4
+      with:
+        dotnet-version: '8.0.x'
+
+    - name: Setup NuGet (Windows)
+      if: runner.os == 'Windows'
+      uses: NuGet/setup-nuget@v2
+
+    - name: Restore NuGet packages (Windows)
+      if: runner.os == 'Windows'
+      run: nuget restore ${{ env.SOLUTION }}
+
+    - name: Restore NuGet packages (Linux/macOS)
+      if: runner.os != 'Windows'
+      run: dotnet restore ${{ env.SOLUTION }}
+
+    - name: Setup MSBuild (Windows)
+      if: runner.os == 'Windows'
+      uses: microsoft/setup-msbuild@v2
+
+    - name: Build solution (Windows)
+      if: runner.os == 'Windows'
+      run: |
+        msbuild ${{ env.SOLUTION }} `
+          /p:DeployOnBuild=true `
+          /p:WebPublishMethod=Package `
+          /p:PackageAsSingleFile=true `
+          /p:SkipInvalidConfigurations=true `
+          /p:DesktopBuildPackageLocation="${{ runner.temp }}\WebApp.zip" `
+          /p:DeployIisAppPath="Default Web Site" `
+          /p:Configuration=${{ env.BUILD_CONFIGURATION }} `
+          /p:Platform="${{ env.BUILD_PLATFORM }}" `
+          /m
+
+    - name: Build solution (Linux/macOS)
+      if: runner.os != 'Windows'
+      run: dotnet build ${{ env.SOLUTION }} --configuration ${{ env.BUILD_CONFIGURATION }}
+
+    - name: Setup Node.js
+      uses: actions/setup-node@v4
+      with:
+        node-version: '20'
+
+    - name: Install Appium
+      run: npm install -g appium
+
+    - name: Run .NET Framework 4.8 unit tests
+      if: runner.os == 'Windows'
+      run: |
+        dotnet test `
+          --no-build `
+          --configuration ${{ env.BUILD_CONFIGURATION }} `
+          --filter "AppiumLocalServerLaunchingTest|DirectConnectTest|AppiumClientConfigTest" `
+          --framework net48 `
+          --logger "trx;LogFileName=test-results-net48.trx" `
+          ./test/integration/Appium.Net.Integration.Tests.csproj
+
+    - name: Run .NET 8 unit tests
+      run: |
+        dotnet test \
+          --no-build \
+          --configuration ${{ env.BUILD_CONFIGURATION }} \
+          --filter "AppiumLocalServerLaunchingTest|DirectConnectTest|AppiumClientConfigTest" \
+          --framework net8.0 \
+          --logger "trx;LogFileName=test-results-net8-${{ matrix.os }}.trx" \
+          ./test/integration/Appium.Net.Integration.Tests.csproj
+      shell: bash
+
+    - name: Publish test results
+      uses: dorny/test-reporter@v1
+      if: always()
+      with:
+        name: Test Results (${{ matrix.os }})
+        path: '**/test-results-*.trx'
+        reporter: dotnet-trx

azure-pipelines.yml

@@ -79,6 +79,11 @@ private static HttpClient CreateHttpClientInstance()
         /// </summary>
         public event DataReceivedEventHandler OutputDataReceived;
 
+        /// <summary>
+        /// Event that can be used to capture the error output of the service
+        /// </summary>
+        public event DataReceivedEventHandler ErrorDataReceived;
+
         /// <summary>
         /// Starts the defined Appium server.
         /// <remarks>
@@ -115,7 +120,9 @@ private async Task StartAsync()
             }
 
             Service.StartInfo.RedirectStandardOutput = true;
+            Service.StartInfo.RedirectStandardError = true;
             Service.OutputDataReceived += (sender, e) => OutputDataReceived?.Invoke(this, e);
+            Service.ErrorDataReceived += (sender, e) => ErrorDataReceived?.Invoke(this, e);
 
             bool isLaunched = false;
             string msgTxt =
@@ -127,6 +134,7 @@ private async Task StartAsync()
                 Service.Start();
 
                 Service.BeginOutputReadLine();
+                Service.BeginErrorReadLine();
             }
             catch (Exception e)
             {

src/Appium.Net/Appium/Service/AppiumLocalService.cs

@@ -14,6 +14,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Text.Json;
 
 namespace OpenQA.Selenium.Appium.Service.Options
 {
@@ -39,7 +40,7 @@ public OptionCollector AddArguments(KeyValuePair<string, string> arguments)
         /// Adds/merges server-specific capabilities
         /// </summary>
         /// <param name="options">is an instance of OpenQA.Selenium.Remote.AppiumOptions</param>
-        /// <returns>the self-reference</returns>        
+        /// <returns>the self-reference</returns>
         public OptionCollector AddCapabilities(AppiumOptions options)
         {
             if (this.options == null)
@@ -128,48 +129,16 @@ private string ParseCapabilitiesIfWindows()
 
         private string ParseCapabilitiesIfUNIX()
         {
-            string result = string.Empty;
-
-            if (options != null)
+            if (options == null)
             {
-                IDictionary<string, object> capabilitiesDictionary = options.ToDictionary();
-
-                foreach (var item in capabilitiesDictionary)
-                {
-                    object value = item.Value;
-
-                    if (value == null)
-                    {
-                        continue;
-                    }
-
-                    if (typeof(string).IsAssignableFrom(value.GetType()))
-                    {
-                        value = $"\"{value}\"";
-                        ;
-                    }
-
-                    else
-                    {
-                        if (typeof(bool).IsAssignableFrom(value.GetType()))
-                        {
-                            value = Convert.ToString(value).ToLowerInvariant();
-                        }
-                    }
-
-                    string key = $"\"{item.Key}\"";
-                    if (string.IsNullOrEmpty(result))
-                    {
-                        result = $"{key}: {value}";
-                    }
-                    else
-                    {
-                        result = result + ", " + key + ": " + value;
-                    }
-                }
+                return string.Empty;
             }
 
-            return "'{" + result + "}'";
+            // Serialize to JSON and escape double quotes so they survive argument parsing
+            var json = JsonSerializer.Serialize(options.ToDictionary());
+            // Escape double quotes with backslash for shell argument
+            var escaped = json.Replace("\"", "\\\"");
+            return $"\"{escaped}\"";
         }
 
         /// <summary>