Refactor console attachment handling in AppiumLocalService

Added a boolean variable to track console attachment status. Simplified error handling by removing redundant try-catch blocks and ensuring proper cleanup in the finally block.

Author: Dor-bl

src/Appium.Net/Appium/Service/AppiumLocalService.cs

@@ -207,46 +207,34 @@ private bool TryGracefulShutdownOnWindows(Process process, int timeoutMs = 5000)
                 return false;
             }
 
+            bool attached = false;
             try
             {
                 SetConsoleCtrlHandler(null, true);
 
-                if (!AttachConsole((uint)process.Id))
+                attached = AttachConsole((uint)process.Id);
+                if (!attached)
                 {
                     return false;
                 }
 
                 if (!GenerateConsoleCtrlEvent(CTRL_C_EVENT, 0))
                 {
-                    FreeConsole();
                     return false;
                 }
 
-                FreeConsole();
-                SetConsoleCtrlHandler(null, false);
-
                 if (process.WaitForExit(timeoutMs))
                 {
                     return true;
                 }
             }
-            catch (Win32Exception)
-            {
-                try
-                {
-                    FreeConsole();
-                    SetConsoleCtrlHandler(null, false);
-                }
-                catch (Win32Exception) { }
-            }
-            catch (InvalidOperationException)
+            finally
             {
-                try
+                if (attached)
                 {
                     FreeConsole();
-                    SetConsoleCtrlHandler(null, false);
                 }
-                catch (Win32Exception) { }
+                SetConsoleCtrlHandler(null, false);
             }
 
             return false;