#565: Issues which were found by codecy were fixed

Also documentation was improved

Author: TikhomirovSergey

docs/Page-objects.md

@@ -238,7 +238,7 @@ import org.openqa.selenium.support.FindBy;
 //The default value is 0 (the highest priority)
 @HowToUseLocators(iOSAutomation = ALL_POSSIBLE)
 @iOSFindBy(someStrategy1)
-@iOSFindBys(value = {@iOSBy(subloctor1), @iOSBy(subloctor1)}, priority = 1) //this possible variant is 
+@iOSFindAll(value = {@iOSBy(subloctor1), @iOSBy(subloctor1)}, priority = 1) //this possible variant is 
 // the chain
 @iOSFindBy(someStrategy2, priority = 2) 
 @iOSFindBy(someStrategy3, priority = 3) 
@@ -248,7 +248,7 @@ RemoteWebElement someElement;
 
 @HowToUseLocators(iOSAutomation = ALL_POSSIBLE)
 @iOSFindBy(someStrategy1)
-@iOSFindBys(value = {@iOSBy(subloctor1), @iOSBy(subloctor1)}, priority = 1) //this possible variant is 
+@iOSFindAll(value = {@iOSBy(subloctor1), @iOSBy(subloctor1)}, priority = 1) //this possible variant is 
 // the chain
 @iOSFindBy(someStrategy2, priority = 2) 
 @iOSFindBy(someStrategy3, priority = 3) 

src/main/java/io/appium/java_client/pagefactory/DefaultElementByBuilder.java

@@ -232,41 +232,41 @@ private By returnMappedBy(By byDefault, By nativeAppBy) {
 
     private static class AnnotationComparator implements Comparator<Annotation> {
 
-        @Override
-        public int compare(Annotation o1, Annotation o2) {
-            int p1;
-            int p2;
-            Method priority1;
-            Method priority2;
-
-            Class<?> c1 = o1.annotationType();
-            Class<?> c2 = o2.annotationType();
-
+        private static Method getPriorityMethod(Class<? extends Annotation> clazz) {
             try {
-                priority1 = c1.getMethod(PRIORITY, ANNOTATION_ARGUMENTS);
+                return clazz.getMethod(PRIORITY, ANNOTATION_ARGUMENTS);
             } catch (NoSuchMethodException e) {
-                throw new ClassCastException(String.format("Class %s has no '%s' method", c1.getName(), PRIORITY));
+                throw new ClassCastException(String.format("Class %s has no '%s' method", clazz.getName(), PRIORITY));
             }
+        }
 
+        private static int getPriorityValue(Method priorityMethod, Annotation annotation,
+                                            Class<? extends Annotation> clazz) {
             try {
-                priority2 = c2.getMethod(PRIORITY, ANNOTATION_ARGUMENTS);
-            } catch (NoSuchMethodException e) {
-                throw new ClassCastException(String.format("Class %s has no '%s' method", c2.getName(), PRIORITY));
+                return (int) priorityMethod.invoke(annotation, ANNOTATION_PARAMETERS);
+            } catch (IllegalAccessException | InvocationTargetException e) {
+                throw new IllegalArgumentException(String
+                        .format("It is impossible to get priority. Annotation class: %s", clazz.toString()), e);
             }
+        }
 
-            try {
-                p1 = (int) priority1.invoke(o1, ANNOTATION_PARAMETERS);
-                p2 = (int) priority2.invoke(o2, ANNOTATION_PARAMETERS);
-
-                if (p2 > p1) {
-                    return -1;
-                } else if (p2 < p1) {
-                    return 1;
-                } else {
-                    return 0;
-                }
-            } catch (IllegalAccessException | InvocationTargetException e) {
-                throw new RuntimeException(e);
+        @Override
+        public int compare(Annotation o1, Annotation o2) {
+            Class<? extends Annotation> c1 = o1.annotationType();
+            Class<? extends Annotation> c2 = o2.annotationType();
+
+            Method priority1 = getPriorityMethod(c1);
+            Method priority2 = getPriorityMethod(c2);
+
+            int p1 = getPriorityValue(priority1, o1, c1);
+            int p2 = getPriorityValue(priority2, o2, c2);
+
+            if (p2 > p1) {
+                return -1;
+            } else if (p2 < p1) {
+                return 1;
+            } else {
+                return 0;
             }
         }
     }