remove duplicated args

Author: KazuCocoa

README.md

@@ -58,6 +58,35 @@ For example, some changes in the Selenium binding could break the Appium client.
 > to keep compatible version combinations.
 
 
+### Quick migration guide from v4 to v5
+- Please use `AppiumClientConfig` as `client_config` arguemnt in favor of client arguments below
+    - `keep_alive`, `direct_connection` and `strict_ssl` arguments.
+        ```python
+        SERVER_URL_BASE = 'http://127.0.0.1:4723'
+        # before
+        driver = webdriver.Remote(
+            SERVER_URL_BASE,
+            options=UiAutomator2Options().load_capabilities(desired_caps),
+            direct_connection=True,
+            keep_alive=False,
+            strict_ssl=False
+        )
+
+        # after
+        from appium.webdriver.client_config import AppiumClientConfig
+        client_config = AppiumClientConfig(
+            remote_server_addr=SERVER_URL_BASE,
+            direct_connection=True,
+            keep_alive=False,
+            ignore_certificates=True,
+        )
+        driver = webdriver.Remote(
+            SERVER_URL_BASE,
+            options=UiAutomator2Options().load_capabilities(desired_caps),
+            client_config=client_config
+        )
+        ```
+
 ### Quick migration guide from v3 to v4
 - Removal
     - `MultiAction` and `TouchAction` are removed. Please use W3C WebDriver actions or `mobile:` extensions
@@ -273,6 +302,7 @@ from appium import webdriver
 # If you use an older client then switch to desired_capabilities
 # instead: https://github.com/appium/python-client/pull/720
 from appium.options.ios import XCUITestOptions
+from appium.webdriver.client_config import AppiumClientConfig
 
 # load_capabilities API could be used to
 # load options mapping stored in a dictionary
@@ -282,11 +312,16 @@ options = XCUITestOptions().load_capabilities({
     'app': '/full/path/to/app/UICatalog.app.zip',
 })
 
+client_config = AppiumClientConfig(
+    remote_server_addr='http://127.0.0.1:4723',
+    direct_connection=True
+)
+
 driver = webdriver.Remote(
     # Appium1 points to http://127.0.0.1:4723/wd/hub by default
     'http://127.0.0.1:4723',
     options=options,
-    direct_connection=True
+    client_config=client_config
 )
 ```
 

appium/webdriver/client_config.py

@@ -13,7 +13,7 @@
 from selenium.webdriver.remote.client_config import ClientConfig
 
 
-class AppiumClientConfg(ClientConfig):
+class AppiumClientConfig(ClientConfig):
     def __init__(self, remote_server_addr: str, *args, **kwargs):
         self._direct_connection = kwargs.pop('direct_connection', False)
         super().__init__(remote_server_addr, *args, **kwargs)

appium/webdriver/webdriver.py

@@ -31,7 +31,7 @@
 from appium.webdriver.common.appiumby import AppiumBy
 
 from .appium_connection import AppiumConnection
-from .client_config import AppiumClientConfg
+from .client_config import AppiumClientConfig
 from .errorhandler import MobileErrorHandler
 from .extensions.action_helpers import ActionHelpers
 from .extensions.android.activities import Activities
@@ -204,17 +204,15 @@ class WebDriver(
 ):
     def __init__(  # noqa: PLR0913
         self,
-        command_executor: Union[str, AppiumConnection] = 'http://127.0.0.1:4444/wd/hub',
+        command_executor: Union[str, AppiumConnection] = 'http://127.0.0.1:4723',
         extensions: Optional[List['WebDriver']] = None,
         options: Union[AppiumOptions, List[AppiumOptions], None] = None,
-        client_config: Optional[AppiumClientConfg] = None,
+        client_config: Optional[AppiumClientConfig] = None,
     ):
-        if client_config is None:
-            # TODO: when command_executor is not string
-            client_config = AppiumClientConfg(remote_server_addr=command_executor)
-
         if isinstance(command_executor, str):
-            command_executor = AppiumConnection(remote_server_addr=command_executor, client_config=client_config)
+            if client_config is None:
+                client_config = AppiumClientConfig(remote_server_addr=command_executor)
+            command_executor = AppiumConnection(client_config=client_config)
 
         super().__init__(
             command_executor=command_executor,