Skip to content

Commit 6d0e752

Browse files
committed
remove pylint etc
1 parent 2f431de commit 6d0e752

File tree

8 files changed

+9
-619
lines changed

8 files changed

+9
-619
lines changed

.pylintrc

Lines changed: 0 additions & 557 deletions
This file was deleted.

Makefile

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -5,22 +5,10 @@ check-all: ## Run all lint checks and unittest
55
@echo "[Notice] If you'd like to run commands with same env to CI, please run \`tox\`."
66
@bash ci.sh
77

8-
.PHONY: isort
9-
isort: ## Run isort
10-
python -m isort --profile black $(ARGS) .
11-
12-
.PHONY: black
13-
black: ## Run black
14-
python -m black $(ARGS) . -l 120 -S
15-
16-
.PHONY: pylint
17-
pylint: ## Run pylint
18-
# TODO Remove --disable=E1136 when no errors in py39
19-
python -m pylint $(ARGS) --load-plugins pylint_quotes --rcfile .pylintrc appium test --disable=E1136
20-
21-
.PHONY: mypy
22-
mypy: ## Run mypy
23-
python -m mypy appium test/functional
8+
.PHONY: ruff
9+
ruff: ## Run ruff
10+
python -m ruff check .
11+
python -m ruff format --check .
2412

2513
.PHONY: unittest
2614
unittest: ## Run unittest

Pipfile

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,13 @@ url = "https://pypi.org/simple"
44
verify_ssl = true
55

66
[dev-packages]
7-
black = "<25.0.0"
87
httpretty = "~=1.1"
9-
isort = "<6.0"
10-
mypy = "<2.0"
118
mock = "~=5.1"
129
pre-commit = "~=2.21"
13-
pylint = "~=3.2.7"
14-
pylint-quotes = "~=0.2.3"
1510
pytest = "~=8.3"
1611
pytest-cov = "~=5.0"
1712
python-dateutil = "~=2.9"
13+
ruff = "~=0.6.9"
1814
tox = "~=4.21"
1915
types-python-dateutil = "~=2.9"
2016

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ driver = webdriver.Remote(custom_executor, options=options)
355355
## Development
356356
357357
- Code Style: [PEP-0008](https://www.python.org/dev/peps/pep-0008/)
358-
- Apply `black`, `isort` and `mypy` as pre commit hook
358+
- Apply `ruff` as pre commit hook
359359
- Run `make` command for development. See `make help` output for details
360360
- Docstring style: [Google Style](https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html)
361361
- `gitchangelog` generates `CHANGELOG.rst`

appium/webdriver/extensions/location.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ def location(self) -> Dict[str, float]:
8585
- longitude (float)
8686
- altitude (float)
8787
"""
88-
return self.execute(Command.GET_LOCATION)['value'] # pylint: disable=unsubscriptable-object
88+
return self.execute(Command.GET_LOCATION)['value']
8989

9090
def _add_commands(self) -> None:
9191
"""Add location endpoints. They are not int w3c spec."""

appium/webdriver/webdriver.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
# pylint: disable=too-many-lines,too-many-public-methods,too-many-statements,no-self-use
16-
1715
from typing import Any, Callable, Dict, List, Optional, Set, Tuple, Union
1816

1917
from selenium import webdriver
@@ -212,11 +210,9 @@ def __init__(
212210
options: Union[AppiumOptions, List[AppiumOptions], None] = None,
213211
):
214212
if strict_ssl is False:
215-
# pylint: disable=E1101
216213
# noinspection PyPackageRequirements
217214
import urllib3
218215

219-
# pylint: disable=E1101
220216
# noinspection PyPackageRequirements
221217
import urllib3.exceptions
222218

ci.sh

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,27 +2,13 @@
22

33
EXIT_STATUS=0
44

5-
if ! make black ARGS=--check ; then
6-
echo "Please run command 'make black' on your local and commit the result"
5+
if ! make ruff ; then
6+
echo "Please run command 'make ruff' on your local and commit the result"
77
EXIT_STATUS=1
88
fi
9-
if ! make isort ARGS=--check-only ; then
10-
echo "Please run command 'make isort' on your local and commit the result"
11-
EXIT_STATUS=1
12-
fi
13-
14-
if ! make pylint ; then
15-
echo "Please run command 'make pylint' on your local and fix errors"
16-
# TODO: pylint erroneously complains about many things it should not complain about
17-
# EXIT_STATUS=1
18-
fi
199

2010
if ! make unittest ARGS=--junitxml=./test/unit/junit.xml ; then
2111
EXIT_STATUS=1
2212
fi
2313

24-
if ! make mypy ; then
25-
EXIT_STATUS=1
26-
fi
27-
2814
exit $EXIT_STATUS

setup.cfg

Lines changed: 0 additions & 19 deletions
This file was deleted.

0 commit comments

Comments
 (0)