add test to check remote_server_addr priority

Author: KazuCocoa

README.md

@@ -76,12 +76,12 @@ For example, some changes in the Selenium binding could break the Appium client.
         # after
         from appium.webdriver.client_config import AppiumClientConfig
         client_config = AppiumClientConfig(
+            remote_server_addr=SERVER_URL_BASE,
             direct_connection=True,
             keep_alive=False,
             ignore_certificates=True,
         )
         driver = webdriver.Remote(
-            SERVER_URL_BASE,
             options=UiAutomator2Options().load_capabilities(desired_caps),
             client_config=client_config
         )

appium/webdriver/webdriver.py

@@ -214,8 +214,6 @@ def __init__(  # noqa: PLR0913
         if isinstance(command_executor, str):
             if client_config is None:
                 client_config = AppiumClientConfig(remote_server_addr=command_executor)
-            else:
-                client_config.remote_server_addr = command_executor
             # To prevent generating RemoteConnection in selenium
             command_executor = AppiumConnection(client_config=client_config)
 

test/unit/webdriver/webdriver_test.py

@@ -175,6 +175,45 @@ def test_create_session_register_uridirect_no_direct_connect_path(self):
         assert ['NATIVE_APP', 'CHROMIUM'] == driver.contexts
         assert isinstance(driver.command_executor, AppiumConnection)
 
+    @httpretty.activate
+    def test_create_session_remote_server_addr_treatment_with_appiumclientconfig(self):
+        # remote server add in AppiumRemoteCong will be prior than the string of 'command_executor'
+        # as same as Selenium behavior.
+        httpretty.register_uri(
+            httpretty.POST,
+            f'{SERVER_URL_BASE}/session',
+            body=json.dumps(
+                {
+                    'sessionId': 'session-id',
+                    'capabilities': {
+                        'deviceName': 'Android Emulator',
+                    },
+                }
+            ),
+        )
+
+        httpretty.register_uri(
+            httpretty.GET,
+            f'{SERVER_URL_BASE}/session/session-id/contexts',
+            body=json.dumps({'value': ['NATIVE_APP', 'CHROMIUM']}),
+        )
+
+        desired_caps = {
+            'platformName': 'Android',
+            'deviceName': 'Android Emulator',
+            'app': 'path/to/app',
+            'automationName': 'UIAutomator2',
+        }
+        client_config = AppiumClientConfig(remote_server_addr=SERVER_URL_BASE, direct_connection=True)
+        driver = webdriver.Remote(
+            'http://localhost:8080/something/path',
+            options=UiAutomator2Options().load_capabilities(desired_caps),
+            client_config=client_config,
+        )
+
+        assert SERVER_URL_BASE == driver.command_executor._client_config.remote_server_addr
+        assert isinstance(driver.command_executor, AppiumConnection)
+
     @httpretty.activate
     def test_get_events(self):
         driver = ios_w3c_driver()