Skip to content

Commit b16a9cc

Browse files
committed
Add remaining optional arguments to start_activity method
1 parent 079e4ec commit b16a9cc

File tree

1 file changed

+21
-6
lines changed

1 file changed

+21
-6
lines changed

appium/webdriver/webdriver.py

Lines changed: 21 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -519,7 +519,7 @@ def close_app(self):
519519
self.execute(Command.CLOSE_APP)
520520
return self
521521

522-
def start_activity(self, app_package, app_activity, app_wait_package='', app_wait_activity=''):
522+
def start_activity(self, app_package, app_activity, **opts):
523523
"""Opens an arbitrary activity during a test. If the activity belongs to
524524
another application, that application is started and the activity is opened.
525525
@@ -528,15 +528,30 @@ def start_activity(self, app_package, app_activity, app_wait_package='', app_wai
528528
:Args:
529529
- app_package - The package containing the activity to start.
530530
- app_activity - The activity to start.
531-
- app_wait_package - Begin automation after this package starts.
532-
- app_wait_activity - Begin automation after this activity starts.
531+
- app_wait_package - Begin automation after this package starts (optional).
532+
- app_wait_activity - Begin automation after this activity starts (optional).
533+
- intent_action - Intent to start (optional).
534+
- intent_category - Intent category to start (optional).
535+
- intent_flags - Flags to send to the intent (optional).
536+
- optional_intent_arguments - Optional arguments to the intent (optional).
537+
- stop_app_on_reset - Should the app be stopped on reset (optional)?
533538
"""
534539
data = {
535540
'appPackage': app_package,
536-
'appActivity': app_activity,
537-
'appWaitPackage': app_wait_package,
538-
'appWaitActivity': app_wait_activity
541+
'appActivity': app_activity
539542
}
543+
arguments = {
544+
'app_wait_package': 'appWaitPackage',
545+
'app_wait_activity': 'appWaitActivity',
546+
'intent_action': 'intentAction',
547+
'intent_category': 'intentCategory',
548+
'intent_flags': 'intentFlags',
549+
'optional_intent_arguments': 'optionalIntentArguments',
550+
'stop_app_on_reset': 'stopAppOnReset'
551+
}
552+
for key in arguments.iterkeys():
553+
if opts.has_key(key):
554+
data[arguments[key]] = opts[key]
540555
self.execute(Command.START_ACTIVITY, data)
541556
return self
542557

0 commit comments

Comments
 (0)