Skip to content

Commit 121316f

Browse files
authored
chore: add deprecated in docstrings for start_logs_broadcast/stop_logs_broadcast (#1095)
* chore: add deprecated in docstrings for start_logs_broadcast/stop_logs_broadcast * add one more todo
1 parent 2736ab2 commit 121316f

File tree

4 files changed

+10
-0
lines changed

4 files changed

+10
-0
lines changed

appium_lib.gemspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ Gem::Specification.new do |s|
1313
s.homepage = 'https://github.com/appium/ruby_lib' # published as appium_lib
1414
s.require_paths = ['lib']
1515

16+
# TODO: We must remove start_logs_broadcast/stop_logs_broadcast to bump the appium_lib_core version to v12+.
1617
s.add_dependency 'appium_lib_core', '>= 9.2.1', '< 12.0'
1718
s.add_dependency 'nokogiri', '~> 1.8', '>= 1.8.1'
1819
s.add_dependency 'tomlrb', '>= 1.1', '< 3.0'

lib/appium_lib/android/common/command/command.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ def shell(command, arguments)
3131
@driver.execute_script 'mobile: shell', args
3232
end
3333

34+
# @deprecated Please use BiDi implementation via `$driver.driver.bidi` directly instead.
35+
#
3436
# Starts Android logcat broadcast websocket
3537
#
3638
# @param [String] logcat_file A file path to write messages from a logcat WebSocket client
@@ -46,6 +48,8 @@ def start_logs_broadcast(logcat_file = 'logcat.log')
4648
@logcat_client = ::Appium::Common::Command::WsLogcat.new(url: socket_url, output_file: logcat_file)
4749
end
4850

51+
# @deprecated Please use BiDi implementation directly instead.
52+
#
4953
# Stop Android logcat broadcast websocket
5054
#
5155
# @example

lib/appium_lib/common/command/ws_logcat.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
module Appium
1616
module Common
1717
module Command
18+
# TODO: Remove this implementation after dropping start_logs_broadcast
1819
class WsLogcat < ::Appium::Core::WebSocket
1920
def initialize(url:, output_file: 'logcat.log')
2021
super(url: url)

lib/appium_lib/ios/xcuitest/command.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ module Appium
2222
module Ios
2323
module Xcuitest
2424
module Command
25+
# @deprecated Please use BiDi implementation via `$driver.driver.bidi` directly instead.
26+
#
2527
# Starts iOS syslog broadcast websocket
2628
#
2729
# @param [String] syslog_file A file path to write messages from a syslog WebSocket client
@@ -37,6 +39,8 @@ def start_logs_broadcast(syslog_file = 'syslog.log')
3739
@logcat_client = ::Appium::Common::Command::WsLogcat.new(url: socket_url, output_file: syslog_file)
3840
end
3941

42+
# @deprecated Please use BiDi implementation directly instead.
43+
#
4044
# Stop iOS syslog broadcast websocket
4145
#
4246
# @example

0 commit comments

Comments
 (0)