test: use newer app for testing and drop ios 13 and lower versions (#653)

* test: use the newer app for testing

* add download_content

* download content

* use join

* remove ios 13 and lower

* remove old app file names as well

* consider redirect as well up to 5

* remove comment

* remove unnecessary comment

* simplify with case and when

* remove env var after the run

* fix android path

* add workaround to download with ssl for github actions

* add rubocop workaround..

* fix rubocop

* update test for the download

* fix syntax

* change the way to run tests

* modify tests to reduce error

Author: KazuCocoa

.rubocop.yml

@@ -1,7 +1,7 @@
 AllCops:
   TargetRubyVersion: 3.1
 Layout/LineLength:
-  Max: 128
+  Enabled: false
 Layout/RescueEnsureAlignment:
   Enabled: false
 Layout/EmptyLinesAroundAttributeAccessor:

README.md

@@ -31,14 +31,14 @@ Run unit tests which check each method and command, URL, using the webmock.
 
 ```bash
 $ bundle install
-$ bundle exec parallel_test test/unit/
+$ UNIT_TEST=1 bundle exec parallel_test test/unit/
 ```
 
 or
 
 ```bash
 $ bundle install
-$ bundle exec rake test:unit
+$ UNIT_TEST=1 bundle exec rake test:unit
 ```
 
 ### Functional Tests

Rakefile

@@ -38,31 +38,27 @@ namespace :test do
   namespace :unit do
     desc('Run all iOS related unit tests in test directory')
     Rake::TestTask.new(:ios) do |t|
-      ENV['UNIT_TEST'] = '1'
       t.libs << 'test'
       t.libs << 'lib'
       t.test_files = FileList['test/unit/ios/**/*_test.rb']
     end
 
     desc('Run all Android related unit tests in test directory')
     Rake::TestTask.new(:android) do |t|
-      ENV['UNIT_TEST'] = '1'
       t.libs << 'test'
       t.libs << 'lib'
       t.test_files = FileList['test/unit/android/**/*_test.rb']
     end
 
     desc('Run all common related unit tests in test directory')
     Rake::TestTask.new(:common) do |t|
-      ENV['UNIT_TEST'] = '1'
       t.libs << 'test'
       t.libs << 'lib'
       t.test_files = FileList['test/unit/common/**/*_test.rb']
     end
 
     desc('Run all Windows related unit tests in test directory')
     Rake::TestTask.new(:windows) do |t|
-      ENV['UNIT_TEST'] = '1'
       t.libs << 'test'
       t.libs << 'lib'
       t.test_files = FileList['test/unit/windows/**/*_test.rb']

lib/appium_lib_core/android/device.rb

@@ -24,8 +24,6 @@ module Android
       module Device
         extend Forwardable
 
-        # rubocop:disable Layout/LineLength
-
         # @!method open_notifications
         #   Open Android notifications
         #
@@ -244,8 +242,6 @@ module Device
         ## class << self
         ####
 
-        # rubocop:enable Layout/LineLength
-
         class << self
           def extended(_mod)
             ::Appium::Core::Device.extend_webdriver_with_forwardable

lib/appium_lib_core/android/device/emulator.rb

@@ -121,9 +121,7 @@ def send_sms(phone_number:, message:)
 
             ::Appium::Core::Device.add_endpoint_method(:gsm_call) do
               def gsm_call(phone_number:, action:)
-                unless GSM_CALL_ACTIONS.member? action.to_sym
-                  raise ::Appium::Core::Error::ArgumentError, "action: should be member of #{GSM_CALL_ACTIONS}. Not #{action}."
-                end
+                raise ::Appium::Core::Error::ArgumentError, "action: should be member of #{GSM_CALL_ACTIONS}. Not #{action}." unless GSM_CALL_ACTIONS.member? action.to_sym
 
                 execute_script 'mobile:gsmCall', { phoneNumber: phone_number, action: action }
               end
@@ -142,9 +140,7 @@ def gsm_signal(signal_strength)
 
             ::Appium::Core::Device.add_endpoint_method(:gsm_voice) do
               def gsm_voice(state)
-                unless GSM_VOICE_STATES.member? state.to_sym
-                  raise ::Appium::Core::Error::ArgumentError, "The state should be member of #{GSM_VOICE_STATES}. Not #{state}."
-                end
+                raise ::Appium::Core::Error::ArgumentError, "The state should be member of #{GSM_VOICE_STATES}. Not #{state}." unless GSM_VOICE_STATES.member? state.to_sym
 
                 execute_script 'mobile:gsmVoice', { state: state }
               end
@@ -163,19 +159,15 @@ def set_network_speed(netspeed)
 
             ::Appium::Core::Device.add_endpoint_method(:set_power_capacity) do
               def set_power_capacity(percent)
-                unless (0..100).member? percent
-                  ::Appium::Logger.warn "The  percent should be between 0 and 100. Not #{percent}."
-                end
+                ::Appium::Logger.warn "The  percent should be between 0 and 100. Not #{percent}." unless (0..100).member? percent
 
                 execute_script 'mobile:powerCapacity', { percent: percent }
               end
             end
 
             ::Appium::Core::Device.add_endpoint_method(:set_power_ac) do
               def set_power_ac(state)
-                unless POWER_AC_STATE.member? state.to_sym
-                  raise ::Appium::Core::Error::ArgumentError, "The state should be member of #{POWER_AC_STATE}. Not #{state}."
-                end
+                raise ::Appium::Core::Error::ArgumentError, "The state should be member of #{POWER_AC_STATE}. Not #{state}." unless POWER_AC_STATE.member? state.to_sym
 
                 execute_script 'mobile:powerAc', { state: state }
               end

lib/appium_lib_core/android/device/screen.rb

@@ -39,9 +39,7 @@ def start_recording_screen(remote_path: nil, user: nil, pass: nil, method: 'PUT'
                 option[:bitRate] = bit_rate unless bit_rate.nil?
 
                 unless bug_report.nil?
-                  unless [true, false].member?(bug_report)
-                    raise ::Appium::Core::Error::ArgumentError, 'bug_report should be true or false'
-                  end
+                  raise ::Appium::Core::Error::ArgumentError, 'bug_report should be true or false' unless [true, false].member?(bug_report)
 
                   option[:bugReport] = bug_report
                 end

lib/appium_lib_core/common/base/bridge.rb

@@ -96,7 +96,7 @@ def attach_to(session_id, platform_name, automation_name)
         #     caps: {
         #       platformName: :ios,
         #       automationName: 'XCUITest',
-        #       app: 'test/functional/app/UICatalog.app.zip',
+        #       app: 'test/functional/app/UIKitCatalog-iphonesimulator.zip',
         #       platformVersion: '11.4',
         #       deviceName: 'iPhone Simulator',
         #       useNewWDA: true,

lib/appium_lib_core/common/base/driver.rb

@@ -196,9 +196,7 @@ def update_sending_request_to(protocol:, host:, port:, path:)
         #   @driver.test_action_command(e.id, 'action')
         #
         def add_command(method:, url:, name:, &block)
-          unless AVAILABLE_METHODS.include? method
-            raise ::Appium::Core::Error::ArgumentError, "Available method is either #{AVAILABLE_METHODS}"
-          end
+          raise ::Appium::Core::Error::ArgumentError, "Available method is either #{AVAILABLE_METHODS}" unless AVAILABLE_METHODS.include? method
 
           @bridge.add_command method: method, url: url, name: name, &block
         end

lib/appium_lib_core/common/base/has_location.rb

@@ -40,9 +40,7 @@ def location
         #   driver.location = ::Appium::Location.new(10, 10, 10)
         #
         def location=(location)
-          unless location.is_a?(::Appium::Location)
-            raise TypeError, "expected #{::Appium::Location}, got #{location.inspect}:#{location.class}"
-          end
+          raise TypeError, "expected #{::Appium::Location}, got #{location.inspect}:#{location.class}" unless location.is_a?(::Appium::Location)
 
           @bridge.set_location location.latitude, location.longitude, location.altitude
         end

lib/appium_lib_core/common/base/rotable.rb

@@ -35,9 +35,7 @@ module Rotatable
         #
         #
         def rotation=(orientation)
-          unless ORIENTATIONS.include?(orientation)
-            raise ::Appium::Core::Error::ArgumentError, "expected #{ORIENTATIONS.inspect}, got #{orientation.inspect}"
-          end
+          raise ::Appium::Core::Error::ArgumentError, "expected #{ORIENTATIONS.inspect}, got #{orientation.inspect}" unless ORIENTATIONS.include?(orientation)
 
           bridge.screen_orientation = orientation.to_s.upcase
         end