fix: convert publicKey to KeyObject for compatibility with Bun #254
+72
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
italodeverdade
changed the title
|
@italodeverdade Would we not just wait for Bun to fix the bug in their API? It looks like this has already been fixed on their end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous versions of Bun, the
publicKeywas generated as aCryptoKeyinstead of aKeyObject, which caused compatibility issues with the library in the Bun environment. This PR adds support for transformingCryptoKeyinstances intoKeyObjects, enabling Bun to successfully perform signature verifications.Reference:
oven-sh/bun#16652