Skip to content

Commit 8cf9057

Browse files
Edwinhr716changlan
authored andcommitted
addressed comments
1 parent b246139 commit 8cf9057

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

axlearn/cloud/gcp/job_test.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ def run(self, result=None):
220220
# Run tests under mock user and settings.
221221
self._settings = default_mock_settings()
222222
with mock_gcp_settings(
223-
[pathways_utils.__name__, bundler.__name__],
223+
[jobset_utils.__name__, bundler.__name__],
224224
settings=self._settings,
225225
):
226226
return super().run(result)
@@ -281,7 +281,9 @@ class Config(Bundler.Config):
281281
self.assertEqual(cfg.name, cfg.builder.name)
282282
self.assertEqual(cfg.project, self._settings["project"])
283283
self.assertEqual(cfg.zone, self._settings["zone"])
284-
self.assertEqual(cfg.builder.reservation, reservation or self._settings["gke_reservation"])
284+
self.assertEqual(
285+
cfg.builder.inner.reservation, reservation or self._settings["gke_reservation"]
286+
)
285287
self.assertEqual(cfg.num_replicas, 1)
286288
# Should work with wrapped bundlers.
287289
if wrap_bundler:

axlearn/cloud/gcp/utils.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@ def delete_k8s_leaderworkerset(name: str, *, namespace: str):
401401
raise
402402

403403

404-
def list_k8s_leaderworkerset(name: str, *, namespace: str) -> list[str]:
404+
def list_k8s_leaderworkerset(*, namespace: str) -> list[str]:
405405
"""List a K8s LWS by name, including all descendant jobs.
406406
407407
Args:
@@ -418,7 +418,6 @@ def list_k8s_leaderworkerset(name: str, *, namespace: str) -> list[str]:
418418
import kubernetes as k8s # pytype: disable=import-error
419419

420420
lws_groups = k8s.client.CustomObjectsApi().list_namespaced_custom_object(
421-
name=name,
422421
namespace=namespace,
423422
propagation_policy="Foreground",
424423
**custom_leaderworkerset_kwargs(),

0 commit comments

Comments
 (0)