Skip to content

Commit 531ccd6

Browse files
authored
vminitd: Rename CgroupManager -> Cgroup2Manager (#266)
To be more explicit.
1 parent 79e07b4 commit 531ccd6

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

vminitd/Sources/vminitd/CgroupManager.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import Foundation
1919
import Logging
2020
import Musl
2121

22-
enum CgroupController: String {
22+
enum Cgroup2Controller: String {
2323
case pids
2424
case memory
2525
case cpuset
@@ -30,7 +30,7 @@ enum CgroupController: String {
3030

3131
// Extremely simple cgroup manager. Our needs are simple for now, and this is
3232
// reflected in the type.
33-
internal struct CgroupManager {
33+
internal struct Cgroup2Manager {
3434
static let defaultMountPoint = URL(filePath: "/sys/fs/cgroup")
3535

3636
static let killFile = "cgroup.kill"
@@ -71,7 +71,7 @@ internal struct CgroupManager {
7171
if fd == -1 {
7272
throw Error.errno(errno: errno, message: "failed to open \(file.path)")
7373
}
74-
defer { Musl.close(fd) }
74+
defer { close(fd) }
7575

7676
let bytes = Array(value.utf8)
7777
let res = Syscall.retrying {
@@ -82,7 +82,7 @@ internal struct CgroupManager {
8282
}
8383
}
8484

85-
func toggleSubtreeControllers(controllers: [CgroupController], enable: Bool) throws {
85+
func toggleSubtreeControllers(controllers: [Cgroup2Controller], enable: Bool) throws {
8686
let value = controllers.map { (enable ? "+" : "-") + $0.rawValue }.joined(separator: " ")
8787
let mountComponents = self.mountPoint.pathComponents
8888
let pathComponents = self.path.pathComponents
@@ -134,7 +134,7 @@ internal struct CgroupManager {
134134
}
135135
}
136136

137-
extension CgroupManager {
137+
extension Cgroup2Manager {
138138
enum Error: Swift.Error, CustomStringConvertible {
139139
case errno(errno: Int32, message: String)
140140

vminitd/Sources/vminitd/ManagedContainer.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ actor ManagedContainer {
2424
let id: String
2525
let initProcess: ManagedProcess
2626

27-
private let cgroupManager: CgroupManager
27+
private let cgroupManager: Cgroup2Manager
2828
private let log: Logger
2929
private let bundle: ContainerizationOCI.Bundle
3030
private var execs: [String: ManagedProcess] = [:]
@@ -52,7 +52,7 @@ actor ManagedContainer {
5252
cgroupsPath = "/container/\(id)"
5353
}
5454

55-
let cgManager = try CgroupManager(
55+
let cgManager = try Cgroup2Manager(
5656
path: URL(filePath: cgroupsPath),
5757
logger: log
5858
)

vminitd/Sources/vminitd/ManagedProcess.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ final class ManagedProcess: Sendable {
3434
private let syncPipe: FileHandle
3535
private let terminal: Bool
3636
private let bundle: ContainerizationOCI.Bundle
37-
private let cgroupManager: CgroupManager
37+
private let cgroupManager: Cgroup2Manager
3838

3939
private struct State {
4040
init(io: IO) {
@@ -75,7 +75,7 @@ final class ManagedProcess: Sendable {
7575
id: String,
7676
stdio: HostStdio,
7777
bundle: ContainerizationOCI.Bundle,
78-
cgroupManager: CgroupManager,
78+
cgroupManager: Cgroup2Manager,
7979
owningPid: Int32? = nil,
8080
log: Logger
8181
) throws {

0 commit comments

Comments
 (0)