Address PR feedback

Author: bioball

pkl-cli/src/test/kotlin/org/pkl/cli/CliTestRunnerTest.kt

@@ -101,10 +101,10 @@ class CliTestRunnerTest {
           facts
             ✘ fail
                4 == 9 (/tempDir/test.pkl, line xx)
-                 |
+                 │
                  false
                1 == 5 (/tempDir/test.pkl, line xx)
-                 |
+                 │
                  false
 
         0.0% tests pass [1/1 failed], 0.0% asserts pass [2/2 failed]
@@ -289,7 +289,7 @@ class CliTestRunnerTest {
           <testcase classname="test.facts" name="foo"></testcase>
           <testcase classname="test.facts" name="bar">
               <failure message="Fact Failure">5 == 9 (/tempDir/test.pkl, line xx)
-        |
+        │
         false</failure>
           </testcase>
           <system-err><![CDATA[9 = 9
@@ -494,7 +494,7 @@ class CliTestRunnerTest {
                 <testcase classname="test1.facts" name="foo"></testcase>
                 <testcase classname="test1.facts" name="bar">
                     <failure message="Fact Failure">5 == 9 (/tempDir/test1.pkl, line xx)
-          |
+          │
           false</failure>
                 </testcase>
             </testsuite>

pkl-core/src/main/java/org/pkl/core/ast/type/VmTypeMismatchException.java

@@ -34,7 +34,7 @@
 /**
  * Indicates that a type check failed. [TypeNode]s use this exception instead of [VmException] to
  * make type checking of union types efficient. Note that any [TruffleBoundary] between throw and
- * catch location of this exception must a `transferToInterpreterOnException = false`. (Currently
+ * catch location of this exception must set `transferToInterpreterOnException = false`. (Currently
  * there aren't any.)
  */
 public abstract class VmTypeMismatchException extends ControlFlowException {

pkl-core/src/main/java/org/pkl/core/runtime/PowerAssertions.java

@@ -328,15 +328,13 @@ private static List<SourceSection> lines(SourceSection sourceSection) {
   }
 
   public static String trimLeadingWhitespace(String str, int n) {
-    var start = 0;
-    var count = 0;
+    var i = 0;
 
-    while (start < str.length() && count < n && Character.isWhitespace(str.charAt(start))) {
-      start++;
-      count++;
+    while (i < str.length() && i < n && Character.isWhitespace(str.charAt(i))) {
+      i++;
     }
 
-    return str.substring(start);
+    return str.substring(i);
   }
 
   private static boolean renderLine(
@@ -486,7 +484,7 @@ public int length() {
 
     @Override
     public void appendTo(AnsiStringBuilder builder) {
-      builder.append(AnsiCode.FAINT, "|");
+      builder.append(AnsiCode.FAINT, "│");
     }
 
     @Override

pkl-core/src/test/files/LanguageSnippetTests/output/classes/constraints5.err

@@ -3,8 +3,8 @@ Type constraint `this >= min` violated.
 Value: 3
 
     this >= min
-    |    |  |
-    3    |  4
+    │    │  │
+    3    │  4
          false
 
 x | max: Int(this >= min)

pkl-core/src/test/files/LanguageSnippetTests/output/classes/unionTypesErrorDifferent2.err

@@ -11,7 +11,7 @@ at unionTypesErrorDifferent2#X.a (file:///$snippetsDir/input/classes/unionTypesE
   Value: List(1, 2, 3)
 
       length > 3
-      |      |
+      │      │
       3      false
 
 x | a = List(1, 2, 3)

pkl-core/src/test/files/LanguageSnippetTests/output/classes/wrongType6.err

@@ -3,8 +3,8 @@ Type constraint `!isEmpty` violated.
 Value: List()
 
     !isEmpty
-    ||
-    |true
+    ││
+    │true
     false
 
 x | names: List<String>(!isEmpty)

pkl-core/src/test/files/LanguageSnippetTests/output/errors/constraintDetails1.err

@@ -3,10 +3,10 @@ Type constraint `firstOneIsSandy` violated.
 Value: new Listing { new Bird { name = "Bob" }; new Bird { name = ? } }
 
     (it: Listing<Bird>) -> it[0].name == "Sandy"
-                           | |   |    |
-                           | |   |    false
-                           | |   "Bob"
-                           | new Bird { name = "Bob" }
+                           │ │   │    │
+                           │ │   │    false
+                           │ │   "Bob"
+                           │ new Bird { name = "Bob" }
                            new Listing { new Bird { name = "Bob" }; new Bird { name = ? } }
 
 x | birds: Listing(firstOneIsSandy) = new {

pkl-core/src/test/files/LanguageSnippetTests/output/errors/constraintDetails2.err

@@ -4,14 +4,14 @@ Type constraint `let (myself: Listing<Bird> = this)
 Value: new Listing { new Bird { name = "Bob" }; new Bird { name = ? } }
 
     let (myself: Listing<Bird> = this)
-                                 |
+                                 │
                                  new Listing { new Bird { name = "Bob" }; new Bird { name = ? } }
 
     myself[0].name == "Sandy"
-    |     |   |    |
-    |     |   |    false
-    |     |   "Bob"
-    |     new Bird { name = "Bob" }
+    │     │   │    │
+    │     │   │    false
+    │     │   "Bob"
+    │     new Bird { name = "Bob" }
     new Listing { new Bird { name = "Bob" }; new Bird { name = ? } }
 
 x | let (myself: Listing<Bird> = this)

pkl-core/src/test/files/LanguageSnippetTests/output/errors/constraintDetails3.err

@@ -3,8 +3,8 @@ Type constraint `toList().every((it: Listing<Bird>) -> it[0].name == "Bob")` vio
 Value: new Listing { new Listing { new Bird { name = "Eagle" }; new Bird { name = ? ...
 
     toList().every((it: Listing<Bird>) -> it[0].name == "Bob")
-    |        |
-    |        false
+    │        │
+    │        false
     List(new Listing { new Bird { name = "Eagle" }; new Bird { name = ? } })
 
 x | foo: Listing(toList().every((it: Listing<Bird>) -> it[0].name == "Bob")) = new {

pkl-core/src/test/files/LanguageSnippetTests/output/errors/intrinsifiedTypeAlias2.err

@@ -3,7 +3,7 @@ Type constraint `isBetween(0, 65535)` violated.
 Value: -1
 
     isBetween(0, 65535)
-    |
+    │
     false
 
 xxxx | typealias UInt16 = Int(isBetween(0, 65535))