Complete repeatable positional instances after the first in bash.

Signed-off-by: Ross Goldberg <[email protected]>

Author: rgoldberg

Sources/ArgumentParser/Completions/BashCompletionsGenerator.swift

@@ -217,7 +217,8 @@ extension CommandInfoV0 {
       result += """
             \(declareTopLevelArray)flags=(\(flagCompletions.joined(separator: " ")))
             \(declareTopLevelArray)options=(\(optionCompletions.joined(separator: " ")))
-            \(offerFlagsOptionsFunctionName) \(positionalArguments.count)
+            \(offerFlagsOptionsFunctionName) \
+        \(positionalArguments.contains { $0.isRepeating } ? 9_223_372_036_854_775_807 : positionalArguments.count)
 
         """
     }
@@ -248,14 +249,23 @@ extension CommandInfoV0 {
         """
     }
 
+    var encounteredRepeatingPositional = false
     let positionalCases =
       zip(1..., positionalArguments)
       .compactMap { position, arg in
+        guard !encounteredRepeatingPositional else {
+          return nil as String?
+        }
+
+        if arg.isRepeating {
+          encounteredRepeatingPositional = true
+        }
+
         let completion = valueCompletion(arg)
         return completion.isEmpty
           ? nil
           : """
-              \(position))
+              \(encounteredRepeatingPositional ? "*" : position.description))
           \(completion.indentingEachLine(by: 8))\
                   return
                   ;;
@@ -375,7 +385,6 @@ extension CommandInfoV0 {
         """
 
     case .custom, .customAsync:
-      // Generate a call back into the command to retrieve a completions list
       return """
         \(addCompletionsFunctionName) -W\
          "$(\(customCompleteFunctionName) \(arg.commonCustomCompletionCall(command: self))\
@@ -385,7 +394,6 @@ extension CommandInfoV0 {
         """
 
     case .customDeprecated:
-      // Generate a call back into the command to retrieve a completions list
       return """
         \(addCompletionsFunctionName) -W\
          "$(\(customCompleteFunctionName) \(arg.commonCustomCompletionCall(command: self)))"

Tests/ArgumentParserExampleTests/Snapshots/testMathBashCompletionScript().bash

@@ -181,13 +181,13 @@ _math() {
 _math_add() {
     flags=(--hex-output -x --version -h --help)
     options=()
-    __math_offer_flags_options 1
+    __math_offer_flags_options 9223372036854775807
 }
 
 _math_multiply() {
     flags=(--hex-output -x --version -h --help)
     options=()
-    __math_offer_flags_options 1
+    __math_offer_flags_options 9223372036854775807
 }
 
 _math_stats() {
@@ -214,7 +214,7 @@ _math_stats() {
 _math_stats_average() {
     flags=(--version -h --help)
     options=(--kind)
-    __math_offer_flags_options 1
+    __math_offer_flags_options 9223372036854775807
 
     # Offer option value completions
     case "${prev}" in
@@ -228,13 +228,13 @@ _math_stats_average() {
 _math_stats_stdev() {
     flags=(--version -h --help)
     options=()
-    __math_offer_flags_options 1
+    __math_offer_flags_options 9223372036854775807
 }
 
 _math_stats_quantiles() {
     flags=(--version -h --help)
     options=(--file --directory --shell --custom --custom-deprecated)
-    __math_offer_flags_options 4
+    __math_offer_flags_options 9223372036854775807
 
     # Offer option value completions
     case "${prev}" in
@@ -280,7 +280,7 @@ _math_stats_quantiles() {
 _math_help() {
     flags=(--version)
     options=()
-    __math_offer_flags_options 1
+    __math_offer_flags_options 9223372036854775807
 }
 
 complete -o filenames -F _math math