Skip to content

Commit ccbedad

Browse files
committed
Don't deallocate channel twice
1 parent 198e6fe commit ccbedad

File tree

2 files changed

+34
-39
lines changed

2 files changed

+34
-39
lines changed

Sources/AsyncDNSResolver/Channel.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ class AresChannel {
2727
private let semaphore = DispatchSemaphore(value: 1)
2828

2929
deinit {
30-
self.pointer?.deallocate()
3130
ares_destroy(self._ares_channel)
3231
ares_library_cleanup()
3332
}

Tests/AsyncDNSResolverTests/AsyncDNSResolverTests.swift

Lines changed: 34 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -126,19 +126,18 @@ final class AsyncDNSResolverTests: XCTestCase {
126126
self.untilFinishOrTimeout(timeout: .seconds(3))
127127
}
128128

129-
// FIXME: this crashes tests
130-
// func test_queryTXT() throws {
131-
// self.resolver.query(.TXT(name: "apple.com") { result in
132-
// switch result {
133-
// case .success(let r):
134-
// print("TXT records: \(r)")
135-
// case .failure(let error):
136-
// print("Error: \(error)")
137-
// }
138-
// })
139-
//
140-
// self.untilFinishOrTimeout(timeout: .seconds(3))
141-
// }
129+
func test_queryTXT() throws {
130+
self.resolver.query(.TXT(name: "apple.com") { result in
131+
switch result {
132+
case .success(let r):
133+
print("TXT records: \(r)")
134+
case .failure(let error):
135+
print("Error: \(error)")
136+
}
137+
})
138+
139+
self.untilFinishOrTimeout(timeout: .seconds(3))
140+
}
142141

143142
func test_querySRV() throws {
144143
self.resolver.query(.SRV(name: "_caldavs._tcp.google.com") { result in
@@ -153,19 +152,18 @@ final class AsyncDNSResolverTests: XCTestCase {
153152
self.untilFinishOrTimeout(timeout: .seconds(3))
154153
}
155154

156-
// FIXME: this crashes tests
157-
// func test_queryNAPTR() throws {
158-
// self.resolver.query(.NAPTR(name: "apple.com") { result in
159-
// switch result {
160-
// case .success(let r):
161-
// print("NAPTR records: \(r)")
162-
// case .failure(let e):
163-
// print("Error: \(e)")
164-
// }
165-
// })
166-
//
167-
// self.untilFinishOrTimeout(timeout: .seconds(3))
168-
// }
155+
func test_queryNAPTR() throws {
156+
self.resolver.query(.NAPTR(name: "apple.com") { result in
157+
switch result {
158+
case .success(let r):
159+
print("NAPTR records: \(r)")
160+
case .failure(let e):
161+
print("Error: \(e)")
162+
}
163+
})
164+
165+
self.untilFinishOrTimeout(timeout: .seconds(3))
166+
}
169167

170168
func test_concurrency() throws {
171169
func run(times: Int = 100, timeout: DispatchTimeInterval = .seconds(5), _ query: (_ index: Int) -> Void) {
@@ -210,23 +208,21 @@ final class AsyncDNSResolverTests: XCTestCase {
210208
print("[MX] Run #\(i) result: \(result)")
211209
})
212210
}
213-
// FIXME: this crashes tests
214-
// run { i in
215-
// self.resolver.query(.TXT(name: "apple.com") { result in
216-
// print("[TXT] Run #\(i) result: \(result)")
217-
// })
218-
// }
211+
run { i in
212+
self.resolver.query(.TXT(name: "apple.com") { result in
213+
print("[TXT] Run #\(i) result: \(result)")
214+
})
215+
}
219216
run { i in
220217
self.resolver.query(.SRV(name: "_caldavs._tcp.google.com") { result in
221218
print("[SRV] Run #\(i) result: \(result)")
222219
})
223220
}
224-
// FIXME: this crashes tests
225-
// run { i in
226-
// self.resolver.query(.NAPTR(name: "apple.com") { result in
227-
// print("[NAPTR] Run #\(i) result: \(result)")
228-
// })
229-
// }
221+
run { i in
222+
self.resolver.query(.NAPTR(name: "apple.com") { result in
223+
print("[NAPTR] Run #\(i) result: \(result)")
224+
})
225+
}
230226
}
231227

232228
/// Waits until channel has no more pending queries or times out.

0 commit comments

Comments
 (0)