DoubleWord.AtomicRepresentation: Use DoubleWord storage on all platforms

We used to use Int64 on 32-bit architectures, but the inconsistency is bothering me. (Even ignoring alignment issues on SysV-derived ABIs on i386.)

Author: lorentey

Sources/Atomics/Conformances/IntegerConformances.swift.gyb

@@ -24,7 +24,7 @@
     ("UInt64",     "Int64",        "Int64"),
     ("Int",        "Int",          "Int"),
     ("UInt",       "Int",          "Int"),
-    ("DoubleWord", "DoubleWord",   "Int64"),
+    ("DoubleWord", "DoubleWord",   "DoubleWord"),
   ]
 }%
 ${autogenerated_warning()}

Sources/Atomics/Conformances/autogenerated/IntegerConformances.swift

@@ -2092,144 +2092,7 @@ extension UInt.AtomicRepresentation: AtomicIntegerStorage {
 
 
 
-#if (compiler(>=5.9) && _pointerBitWidth(_32)) || (compiler(<5.9) && (arch(i386) || arch(arm) || arch(arm64_32) || arch(wasm32)))
-extension DoubleWord: AtomicValue {
-  @frozen
-  public struct AtomicRepresentation {
-    public typealias Value = DoubleWord
-
-#if ATOMICS_NATIVE_BUILTINS
-    @usableFromInline
-    internal typealias _Storage = Int64
-#else
-    @usableFromInline
-    internal typealias _Storage = _AtomicInt64Storage
-#endif
-
-    @usableFromInline
-    internal var _storage: _Storage
-
-    @inline(__always) @_alwaysEmitIntoClient
-    public init(_ value: Value) {
-#if ATOMICS_NATIVE_BUILTINS
-      _storage = unsafeBitCast(value, to: Int64.self)
-#else
-      _storage = _sa_prepare_Int64(unsafeBitCast(value, to: Int64.self))
-#endif
-    }
-
-    @inline(__always) @_alwaysEmitIntoClient
-    public func dispose() -> Value {
-#if ATOMICS_NATIVE_BUILTINS
-      return unsafeBitCast(_storage, to: DoubleWord.self)
-#else
-      let v = _sa_dispose_Int64(_storage)
-      return unsafeBitCast(v, to: DoubleWord.self)
-#endif
-    }
-  }
-}
-
-extension UnsafeMutablePointer
-where Pointee == DoubleWord.AtomicRepresentation {
-  @inlinable @inline(__always)
-  internal var _extract: UnsafeMutablePointer<Pointee._Storage> {
-    // `DoubleWord.AtomicRepresentation` is layout-compatible with
-    // its only stored property.
-    UnsafeMutableRawPointer(self).assumingMemoryBound(to: Pointee._Storage.self)
-  }
-}
-
-extension DoubleWord.AtomicRepresentation: AtomicStorage {
-  @_semantics("atomics.requires_constant_orderings")
-  @_transparent @_alwaysEmitIntoClient
-  public static func atomicLoad(
-    at pointer: UnsafeMutablePointer<Self>,
-    ordering: AtomicLoadOrdering
-  ) -> DoubleWord {
-    let r = pointer._extract._atomicLoad(ordering: ordering)
-    return unsafeBitCast(r, to: DoubleWord.self)
-  }
 
-  @_semantics("atomics.requires_constant_orderings")
-  @_transparent @_alwaysEmitIntoClient
-  public static func atomicStore(
-    _ desired: DoubleWord,
-    at pointer: UnsafeMutablePointer<Self>,
-    ordering: AtomicStoreOrdering
-  ) {
-    pointer._extract._atomicStore(
-      unsafeBitCast(desired, to: Int64.self),
-      ordering: ordering)
-  }
-
-  @_semantics("atomics.requires_constant_orderings")
-  @_transparent @_alwaysEmitIntoClient
-  public static func atomicExchange(
-    _ desired: DoubleWord,
-    at pointer: UnsafeMutablePointer<Self>,
-    ordering: AtomicUpdateOrdering
-  ) -> DoubleWord {
-    let r = pointer._extract._atomicExchange(
-      unsafeBitCast(desired, to: Int64.self),
-      ordering: ordering)
-    return unsafeBitCast(r, to: DoubleWord.self)
-  }
-
-  @_semantics("atomics.requires_constant_orderings")
-  @_transparent @_alwaysEmitIntoClient
-  public static func atomicCompareExchange(
-    expected: DoubleWord,
-    desired: DoubleWord,
-    at pointer: UnsafeMutablePointer<Self>,
-    ordering: AtomicUpdateOrdering
-  ) -> (exchanged: Bool, original: DoubleWord) {
-    let r = pointer._extract._atomicCompareExchange(
-      expected: unsafeBitCast(expected, to: Int64.self),
-      desired: unsafeBitCast(desired, to: Int64.self),
-      ordering: ordering)
-    return (r.exchanged, unsafeBitCast(r.original, to: DoubleWord.self))
-  }
-
-  @_semantics("atomics.requires_constant_orderings")
-  @_transparent @_alwaysEmitIntoClient
-  public static func atomicCompareExchange(
-    expected: DoubleWord,
-    desired: DoubleWord,
-    at pointer: UnsafeMutablePointer<Self>,
-    successOrdering: AtomicUpdateOrdering,
-    failureOrdering: AtomicLoadOrdering
-  ) -> (exchanged: Bool, original: DoubleWord) {
-    let r = pointer._extract._atomicCompareExchange(
-      expected: unsafeBitCast(expected, to: Int64.self),
-      desired: unsafeBitCast(desired, to: Int64.self),
-      successOrdering: successOrdering,
-      failureOrdering: failureOrdering)
-    return (r.exchanged, unsafeBitCast(r.original, to: DoubleWord.self))
-  }
-
-  @_semantics("atomics.requires_constant_orderings")
-  @_transparent @_alwaysEmitIntoClient
-  public static func atomicWeakCompareExchange(
-    expected: DoubleWord,
-    desired: DoubleWord,
-    at pointer: UnsafeMutablePointer<Self>,
-    successOrdering: AtomicUpdateOrdering,
-    failureOrdering: AtomicLoadOrdering
-  ) -> (exchanged: Bool, original: DoubleWord) {
-    let r = pointer._extract._atomicWeakCompareExchange(
-      expected: unsafeBitCast(expected, to: Int64.self),
-      desired: unsafeBitCast(desired, to: Int64.self),
-      successOrdering: successOrdering,
-      failureOrdering: failureOrdering)
-    return (r.exchanged, unsafeBitCast(r.original, to: DoubleWord.self))
-  }
-}
-
-
-
-
-#else /* (compiler(>=5.9) && _pointerBitWidth(_32)) || (compiler(<5.9) && (arch(i386) || arch(arm) || arch(arm64_32) || arch(wasm32))) */
 extension DoubleWord: AtomicValue {
   @frozen
   public struct AtomicRepresentation {
@@ -2363,5 +2226,5 @@ extension DoubleWord.AtomicRepresentation: AtomicStorage {
   }
 }
 
-#endif /* (compiler(>=5.9) && _pointerBitWidth(_32)) || (compiler(<5.9) && (arch(i386) || arch(arm) || arch(arm64_32) || arch(wasm32))) */
+