[PoC] A LogHandler with a live-configurable log level #45
+178
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czechboy0
added
the
status/needs-design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Proving out how a live-configurable log handler could work, which can control the log level using a hot-reloaded configuration value.
This can be super useful in production systems when an issue is being observed and you'd want to emit more logs to debug it, without restarting the server.
Or, if a server is running under high load, this can be used to reduce the log level to create more CPU headroom.
Modifications
Added a type that is both a Service and a LogHandler, watching the value
logLevelfrom a provided ConfigReader.Result
A new type that can be used with Swift Log.
Test Plan
Only a proof-of-concept, haven't tested it much yet, looking for feedback if this is useful and if we should put more energy into cleaning it up and adding it.