ContainerRegistry: Tolerate missing Content-Type header in registry response

euanh · euanh · commit cd64747d09f2 · 2024-10-15T09:08:37.000+01:00
diff --git a/Sources/ContainerRegistry/HTTPClient.swift b/Sources/ContainerRegistry/HTTPClient.swift
@@ -81,12 +81,6 @@ extension URLSession: HTTPClient {
                 }
             }
 
-            // Content-Type should always be set, but there may be registries which don't set it.   If it is not present, the HTTP standard allows
-            // clients to guess the content type, or default to `application/octet-stream'.
-            guard let _ = response.headerFields[.contentType] else {
-                throw HTTPClientError.missingResponseHeader("Content-Type")
-            }
-
             // A HEAD request has no response body and cannot be decoded
             if request.method == .head {
                 throw HTTPClientError.unexpectedStatusCode(status: response.status, response: response, data: nil)

Original file line number	Diff line number	Diff line change
`@@ -81,12 +81,6 @@ extension URLSession: HTTPClient {`
`81`	`81`	`}`
`82`	`82`	`}`
`83`	`83`
`84`		`- // Content-Type should always be set, but there may be registries which don't set it. If it is not present, the HTTP standard allows`
`85`		- // clients to guess the content type, or default to `application/octet-stream'.
`86`		`- guard let _ = response.headerFields[.contentType] else {`
`87`		`- throw HTTPClientError.missingResponseHeader("Content-Type")`
`88`		`- }`
`89`		`-`
`90`	`84`	`// A HEAD request has no response body and cannot be decoded`
`91`	`85`	`if request.method == .head {`
`92`	`86`	`throw HTTPClientError.unexpectedStatusCode(status: response.status, response: response, data: nil)`