Merge pull request #93 from slashmo/feature/write-only-span-events

Remove events getter from Span protocol

Author: ktoso

Package.resolved

@@ -51,10 +51,6 @@ public struct NoOpTracingInstrument: TracingInstrument {
             .init()
         }
 
-        public var events: [SpanEvent] {
-            []
-        }
-
         public mutating func addLink(_ link: SpanLink) {}
 
         public mutating func addEvent(_ event: SpanEvent) {}

Sources/Instrumentation/Tracing/NoOpTracing.swift

@@ -39,11 +39,6 @@ public protocol Span {
     /// The read-only `BaggageContext` of this `Span`, set when starting this `Span`.
     var baggage: BaggageContext { get }
 
-    /// The read-only collection of events which happened within this `Span`.
-    ///
-    /// `SpanEvent`s might be added via the `addEvent` or `addingEvent` `Span` methods.
-    var events: [SpanEvent] { get }
-
     /// Add a `SpanEvent` in place.
     /// - Parameter event: The `SpanEvent` to add to this `Span`.
     mutating func addEvent(_ event: SpanEvent)

Sources/Instrumentation/Tracing/Span.swift

@@ -94,7 +94,7 @@ private final class TracedLockPrintlnTracer: TracingInstrument {
 
         private(set) var links = [SpanLink]()
 
-        private(set) var events = [SpanEvent]() {
+        private var events = [SpanEvent]() {
             didSet {
                 self.isRecording = !self.events.isEmpty
             }