Skip to content

Commit 98173e8

Browse files
committed
Use new BaggageLogging API in end-to-end example
1 parent 592b539 commit 98173e8

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

UseCases/Sources/HTTPEndToEnd/InstrumentedHTTPClient.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,15 @@ import AsyncHTTPClient
1515
import Baggage
1616
import BaggageLogging
1717
import Instrumentation
18+
import Logging
1819
import NIO
1920
import NIOHTTP1
2021
import NIOInstrumentation
2122

2223
struct InstrumentedHTTPClient {
2324
private let client: HTTPClient
2425
private let instrument: Instrument
26+
private let logger = Logger(label: "InstrumentedHTTPClient")
2527

2628
init(instrument: Instrument, eventLoopGroupProvider: HTTPClient.EventLoopGroupProvider) {
2729
self.client = HTTPClient(eventLoopGroupProvider: eventLoopGroupProvider)
@@ -41,7 +43,7 @@ struct InstrumentedHTTPClient {
4143
func execute(request: HTTPClient.Request, context: BaggageContext) -> EventLoopFuture<HTTPClient.Response> {
4244
var request = request
4345
self.instrument.inject(context, into: &request.headers, using: HTTPHeadersInjector())
44-
// context.logger.info("🌎 InstrumentedHTTPClient: Execute request")
46+
self.logger.with(context: context).info("🌎 InstrumentedHTTPClient: Execute request")
4547
return self.client.execute(request: request)
4648
}
4749

UseCases/Sources/HTTPEndToEnd/Services/OrderServiceHandler.swift

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
import AsyncHTTPClient
1515
import Baggage
16+
import BaggageLogging
1617
import Instrumentation
1718
import Logging
1819
import NIO
@@ -39,12 +40,10 @@ final class OrderServiceHandler: ChannelInboundHandler {
3940

4041
self.instrument.extract(requestHead.headers, into: &baggage, using: HTTPHeadersExtractor())
4142

42-
// baggage.logger.info("🧾 Received order request")
43-
self.logger.info("🧾 Received order request")
43+
self.logger.with(context: baggage).info("🧾 Received order request")
4444

4545
context.eventLoop.scheduleTask(in: .seconds(1)) {
46-
// baggage.logger.info("🧾 Asking StorageService if your product exists")
47-
self.logger.info("🧾 Asking StorageService if your product exists")
46+
self.logger.with(context: baggage).info("🧾 Asking StorageService if your product exists")
4847

4948
let request = try! HTTPClient.Request(url: "http://localhost:8081")
5049
self.httpClient.execute(request: request, context: baggage).whenComplete { _ in

UseCases/Sources/HTTPEndToEnd/Services/StorageServiceHandler.swift

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,10 @@ final class StorageServiceHandler: ChannelInboundHandler {
3535
var baggage = BaggageContext()
3636
self.instrument.extract(requestHead.headers, into: &baggage, using: HTTPHeadersExtractor())
3737

38-
// baggage.logger.info("📦 Looking for the product")
39-
self.logger.info("📦 Looking for the product")
38+
self.logger.with(context: baggage).info("📦 Looking for the product")
4039

4140
context.eventLoop.scheduleTask(in: .seconds(2)) {
42-
// baggage.logger.info("📦 Found the product")
43-
self.logger.info("📦 Found the product")
41+
self.logger.with(context: baggage).info("📦 Found the product")
4442
let responseHead = HTTPResponseHead(version: requestHead.version, status: .ok)
4543
context.eventLoop.execute {
4644
context.channel.write(self.wrapOutboundOut(.head(responseHead)), promise: nil)

0 commit comments

Comments
 (0)