[PATCH] [bug] Fix ignored at argument in two instances of withSpan (#139)

* [PATCH] [bug] Fix ignored `at` argument in two instances of
 `withSpan`

In two cases, the signature for `withSpan` included the `at` parameter
to override the starting timestamp on the span, but it was being ignored
and `DefaultTracerClock.now` was being used instead.

* add test

Author: ktoso

Sources/Tracing/Tracer.swift

@@ -195,7 +195,7 @@ public func withSpan<T, Instant: TracerInstant>(
 ) rethrows -> T {
     try InstrumentationSystem.legacyTracer.withAnySpan(
         operationName,
-        at: DefaultTracerClock.now,
+        at: instant(),
         context: context(),
         ofKind: kind,
         function: function,
@@ -339,7 +339,7 @@ public func withSpan<T, Instant: TracerInstant>(
 ) async rethrows -> T {
     try await InstrumentationSystem.legacyTracer.withAnySpan(
         operationName,
-        at: DefaultTracerClock.now,
+        at: instant(),
         context: context(),
         ofKind: kind,
         function: function,

Tests/TracingTests/TracerTests.swift

@@ -369,6 +369,22 @@ final class TracerTests: XCTestCase {
         tracer.withAnySpan("", context: .topLevel) { _ in }
     }
 
+    func testWithSpanShouldNotMissPropagatingInstant() {
+        let tracer = TestTracer()
+        InstrumentationSystem.bootstrapInternal(tracer)
+        defer {
+            InstrumentationSystem.bootstrapInternal(nil)
+        }
+
+        let clock = DefaultTracerClock()
+
+        let instant = clock.now
+        withSpan("span", at: instant) { _ in }
+
+        let span = tracer.spans.first!
+        XCTAssertEqual(span.startTimestampNanosSinceEpoch, instant.nanosecondsSinceEpoch)
+    }
+
     #if swift(>=5.7.0)
 //    @available(macOS 13.0, iOS 16.0, watchOS 9.0, tvOS 16.0, *)
     /// Helper method to execute async operations until we can use async tests (currently incompatible with the generated LinuxMain file).