Merged
Conversation
Motivation: The nightly CI checks for Integration Tests started failing since run https://github.com/apple/swift-nio-http2/actions/runs/19310336168/job/55228659542 (on 12 November 2025). The reason for the failures is due to the `test_client_server_h1_request_response` requiring 282,000 allocations, exceeding the threshold boundary which is currently set to 280,050 across all versions. The date the allocations started to exceed the boundary coincides with [release 2.89.0 of swift-nio](https://github.com/apple/swift-nio/releases/tag/2.89.0). In particular, that test uses `EmbeddedChannel`, and `EmbeddedChannel` was changed in [a PR contained in that release](apple/swift-nio#3442), that introduced some changes leading to greater allocations. [Another change to `EmbeddedChannel`](apple/swift-nio#3495) in `swift-nio`'s latest release ([2.94.0](https://github.com/apple/swift-nio/releases)) has increased the number of allocations of the `client_server_h1_request_response` test to 284,000. We should update the allocation thresholds for that test accordingly. Modifications: Updated the allocation threshold for `client_server_h1_request_response` to 284,000 across all versions. Result: Integration tests should no longer fail.
Lukasa
approved these changes
Feb 9, 2026
aryan-25
changed the title
Lukasa
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The nightly CI checks for Integration Tests started failing since run https://github.com/apple/swift-nio-http2/actions/runs/19310336168/job/55228659542 (on 12 November 2025) due to multiple allocation benchmark tests exceeding their allocation thresholds.
The date these failures started coincides with release 2.89.0 of
swift-nio. In particular, all failing allocation benchmarks useEmbeddedChannel, andEmbeddedChannelwas changed in a PR contained in that release that introduced some changes leading to greater allocations.Another change to
EmbeddedChannelinswift-nio's latest release (2.94.0) has also increased the number of allocations in benchmarks usingEmbeddedChannel.As such, we should update the allocation thresholds for affected tests accordingly.
Modifications:
Updated the allocation threshold for all affected tests across all versions.
Result:
Integration tests should no longer fail.