Skip to content

Commit 603edba

Browse files
authored
Fix naming in Wasm Swift SDK workflow (#3423)
"SDK" and "Swift SDK" are different concepts, compare `swift build --help | grep sdk` output, where we have separate CLI options for these with different meaning: * SDK is used by Clang and Xcode, with Swift Driver also implementing the `-sdk` flag. There's no specification for how Clang SDKs are distributed, thus we don't distribute any Wasm SDK as such. * Swift SDK is purely a SwiftPM feature, which uses artifact bundles for distribution. We do distribute Swift SDKs for Wasm. Same for static Linux BTW, so a separate PR is needed to clean up that confusion for Musl-related CI workflows. Additionally, Wasm is not an acronym. Per the Wasm spec https://webassembly.github.io/spec/core/intro/introduction.html#wasm: > A contraction of “WebAssembly”, not an acronym, hence not using all-caps.
1 parent 102fa28 commit 603edba

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

.github/workflows/wasm_sdk.yml renamed to .github/workflows/wasm_swift_sdk.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: WebAssembly SDK
1+
name: WebAssembly Swift SDK
22

33
permissions:
44
contents: read
@@ -12,15 +12,15 @@ on:
1212
default: "{}"
1313
additional_command_arguments:
1414
type: string
15-
description: "Additional arguments passed to swift build (the WASM SDK will be specified). Defaults to empty."
15+
description: "Additional arguments passed to swift build (the Wasm Swift SDK will be specified). Defaults to empty."
1616
default: ""
1717

1818
jobs:
1919
construct-matrix:
20-
name: Construct WebAssembly SDK matrix
20+
name: Construct WebAssembly Swift SDK matrix
2121
runs-on: ubuntu-latest
2222
outputs:
23-
wasm-sdk-matrix: '${{ steps.generate-matrix.outputs.wasm-sdk-matrix }}'
23+
wasm-swift-sdk-matrix: '${{ steps.generate-matrix.outputs.wasm-swift-sdk-matrix }}'
2424
steps:
2525
- name: Checkout repository
2626
uses: actions/checkout@v4
@@ -39,7 +39,7 @@ jobs:
3939
4040
# Generate matrix with parsed environment variables
4141
cat >> "$GITHUB_OUTPUT" << EOM
42-
wasm-sdk-matrix=$(echo '{
42+
wasm-swift-sdk-matrix=$(echo '{
4343
"config":[
4444
{
4545
"name":"main Jammy",
@@ -56,11 +56,11 @@ jobs:
5656
}' | jq -c)
5757
EOM
5858
59-
wasm-sdk:
60-
name: WebAssembly SDK
59+
wasm-swift-sdk:
60+
name: WebAssembly Swift SDK
6161
needs: construct-matrix
6262
# Workaround https://github.com/nektos/act/issues/1875
6363
uses: apple/swift-nio/.github/workflows/swift_test_matrix.yml@main
6464
with:
65-
name: "WebAssembly SDK"
66-
matrix_string: '${{ needs.construct-matrix.outputs.wasm-sdk-matrix }}'
65+
name: "WebAssembly Swift SDK"
66+
matrix_string: '${{ needs.construct-matrix.outputs.wasm-swift-sdk-matrix }}'

0 commit comments

Comments
 (0)