Enable all feature flags for 0.3.0 (#296)

Enable all feature flags for 0.3.0

### Motivation

0.3.0 is an API-breaking version, so let's take the opportunity to enable all feature flags and delete them.

### Modifications

Deleted all feature flags, all the staged behavior is now enabled by default.

### Result

Simplified codebase again, we only support the new behavior.

### Test Plan

Adapted tests as well.



Reviewed by: simonjbeaumont

Builds:
     ✔︎ pull request validation (5.8) - Build finished. 
     ✔︎ pull request validation (5.9) - Build finished. 
     ✔︎ pull request validation (compatibility test) - Build finished. 
     ✔︎ pull request validation (docc test) - Build finished. 
     ✔︎ pull request validation (nightly) - Build finished. 
     ✔︎ pull request validation (soundness) - Build finished. 
     ✖︎ pull request validation (integration test) - Build finished. 

#296

Author: czechboy0

Sources/_OpenAPIGeneratorCore/FeatureFlags.swift

@@ -26,16 +26,8 @@
 /// 0.2 is tagged. (This is for pre-1.0 versioning, would be 1.0 and 2.0 after
 /// 1.0 is released.)
 public enum FeatureFlag: String, Hashable, Codable, CaseIterable, Sendable {
-
-    /// Support for `nullable` schemas.
-    ///
-    /// A dedicated field in OpenAPI 3.0, a `null` value present in
-    /// the `types` array in OpenAPI 3.1.
-    case nullableSchemas
-
-    /// Support for `application/x-www-form-urlencoded` request bodies as
-    /// structured payloads.
-    case urlEncodedForm
+    // needs to be here for the enum to compile
+    case empty
 }
 
 /// A set of enabled feature flags.

Sources/_OpenAPIGeneratorCore/Translator/Content/ContentInspector.swift

@@ -231,15 +231,14 @@ extension FileTranslator {
                 schema: contentValue.schema
             )
         }
-        let urlEncodedFormsSupported = config.featureFlags.contains(.urlEncodedForm)
-        if urlEncodedFormsSupported && contentKey.isUrlEncodedForm {
+        if contentKey.isUrlEncodedForm {
             let contentType = ContentType(contentKey.typeAndSubtype)
             return .init(
                 contentType: contentType,
                 schema: contentValue.schema
             )
         }
-        if !excludeBinary, contentKey.isBinary || !urlEncodedFormsSupported {
+        if !excludeBinary, contentKey.isBinary {
             let contentType = contentKey.asGeneratorContentType
             return .init(
                 contentType: contentType,

Sources/_OpenAPIGeneratorCore/Translator/FileTranslator+FeatureFlags.swift

@@ -15,10 +15,4 @@ import OpenAPIKit
 
 extension FileTranslator {
     // Add helpers for reading feature flags below.
-
-    /// A Boolean value indicating whether the `nullable` field on schemas
-    /// should be taken into account.
-    var supportNullableSchemas: Bool {
-        config.featureFlags.contains(.nullableSchemas)
-    }
 }

Sources/_OpenAPIGeneratorCore/Translator/TypeAssignment/TypeAssigner.swift

@@ -45,10 +45,6 @@ struct TypeAssigner {
     /// safe to be used as a Swift identifier.
     var asSwiftSafeName: (String) -> String
 
-    /// A Boolean value indicating whether the `nullable` field on schemas
-    /// should be taken into account.
-    var supportNullableSchemas: Bool
-
     /// Returns a type name for an OpenAPI-named component type.
     ///
     /// A component type is any type in `#/components` in the OpenAPI document.
@@ -261,8 +257,7 @@ struct TypeAssigner {
         // creating a new inline type.
         if let referenceableType =
             try TypeMatcher(
-                asSwiftSafeName: asSwiftSafeName,
-                supportNullableSchemas: supportNullableSchemas
+                asSwiftSafeName: asSwiftSafeName
             )
             .tryMatchReferenceableType(for: schema)
         {
@@ -460,16 +455,14 @@ extension FileTranslator {
     /// A configured type assigner.
     var typeAssigner: TypeAssigner {
         TypeAssigner(
-            asSwiftSafeName: swiftSafeName,
-            supportNullableSchemas: supportNullableSchemas
+            asSwiftSafeName: swiftSafeName
         )
     }
 
     /// A configured type matcher.
     var typeMatcher: TypeMatcher {
         TypeMatcher(
-            asSwiftSafeName: swiftSafeName,
-            supportNullableSchemas: supportNullableSchemas
+            asSwiftSafeName: swiftSafeName
         )
     }
 }

Sources/_OpenAPIGeneratorCore/Translator/TypeAssignment/TypeMatcher.swift

@@ -20,10 +20,6 @@ struct TypeMatcher {
     /// safe to be used as a Swift identifier.
     var asSwiftSafeName: (String) -> String
 
-    /// A Boolean value indicating whether the `nullable` field on schemas
-    /// should be taken into account.
-    var supportNullableSchemas: Bool
-
     /// Returns the type name of a built-in type that matches the specified
     /// schema.
     ///
@@ -83,8 +79,7 @@ struct TypeMatcher {
                     return nil
                 }
                 return try TypeAssigner(
-                    asSwiftSafeName: asSwiftSafeName,
-                    supportNullableSchemas: supportNullableSchemas
+                    asSwiftSafeName: asSwiftSafeName
                 )
                 .typeName(for: ref).asUsage
             },
@@ -95,7 +90,7 @@ struct TypeMatcher {
                 TypeName.arrayContainer.asUsage
             }
         )?
-        .withOptional(!schema.required || (supportNullableSchemas && schema.nullable))
+        .withOptional(!schema.required || schema.nullable)
     }
 
     /// Returns a Boolean value that indicates whether the schema

Tests/OpenAPIGeneratorReferenceTests/FileBasedReferenceTests.swift

@@ -45,12 +45,7 @@ class FileBasedReferenceTests: XCTestCase {
     }
 
     func testPetstore() throws {
-        try _test(
-            referenceProject: .init(name: .petstore),
-            featureFlags: [
-                .urlEncodedForm
-            ]
-        )
+        try _test(referenceProject: .init(name: .petstore))
     }
 
     // MARK: - Private

Tests/OpenAPIGeneratorReferenceTests/SnippetBasedReferenceTests.swift

@@ -103,53 +103,6 @@ final class SnippetBasedReferenceTests: XCTestCase {
 
     func testComponentsSchemasNullableStringProperty() throws {
         try self.assertSchemasTranslation(
-            """
-            schemas:
-              MyObj:
-                type: object
-                properties:
-                  fooOptional:
-                    type: string
-                  fooRequired:
-                    type: string
-                  fooOptionalNullable:
-                    type: [string, null]
-                  fooRequiredNullable:
-                    type: [string, null]
-                required:
-                  - fooRequired
-                  - fooRequiredNullable
-            """,
-            """
-            public enum Schemas {
-                public struct MyObj: Codable, Hashable, Sendable {
-                    public var fooOptional: Swift.String?
-                    public var fooRequired: Swift.String
-                    public var fooOptionalNullable: Swift.String?
-                    public var fooRequiredNullable: Swift.String
-                    public init(
-                        fooOptional: Swift.String? = nil,
-                        fooRequired: Swift.String,
-                        fooOptionalNullable: Swift.String? = nil,
-                        fooRequiredNullable: Swift.String
-                    ) {
-                        self.fooOptional = fooOptional
-                        self.fooRequired = fooRequired
-                        self.fooOptionalNullable = fooOptionalNullable
-                        self.fooRequiredNullable = fooRequiredNullable
-                    }
-                    public enum CodingKeys: String, CodingKey {
-                        case fooOptional
-                        case fooRequired
-                        case fooOptionalNullable
-                        case fooRequiredNullable
-                    }
-                }
-            }
-            """
-        )
-        try self.assertSchemasTranslation(
-            featureFlags: [.nullableSchemas],
             """
             schemas:
               MyObj:
@@ -1160,28 +1113,6 @@ final class SnippetBasedReferenceTests: XCTestCase {
 
     func testComponentsRequestBodiesInline_urlEncodedForm() throws {
         try self.assertRequestBodiesTranslation(
-            """
-            requestBodies:
-              MyRequestBody:
-                content:
-                  application/x-www-form-urlencoded:
-                    schema:
-                      type: object
-                      properties:
-                        foo:
-                          type: string
-                      required: [foo]
-            """,
-            """
-            public enum RequestBodies {
-                @frozen public enum MyRequestBody: Sendable, Hashable {
-                    case urlEncodedForm(OpenAPIRuntime.HTTPBody)
-                }
-            }
-            """
-        )
-        try self.assertRequestBodiesTranslation(
-            featureFlags: [.urlEncodedForm],
             """
             requestBodies:
               MyRequestBody: