Skip to content

Commit 11f1629

Browse files
authored
[Examples] Stop linking transitive dependencies in tests (#487)
### Motivation In Swift 5.9.2, a bug is fixed that forced us to previously explicitly link transitive dependencies in tests. So let's remove it, and also bump the swift-tools-version of the affected projects to 5.9.2 to make it explicit. ### Modifications Removed the explicit linkage, bumped the swift-tools-version. ### Result Examples show the best practices using the latest tools. ### Test Plan Ran locally using: ``` docker run --rm -it -v $PWD/Examples/hello-world-hummingbird-server-example:/app swift:5.9 swift test --package-path /app ``` Failed with 5.9.1. Passed with 5.9.2 (and 5.9, which is now an alias for 5.9.2).
1 parent c0402fe commit 11f1629

File tree

3 files changed

+6
-30
lines changed

3 files changed

+6
-30
lines changed

Examples/hello-world-hummingbird-server-example/Package.swift

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// swift-tools-version:5.9
1+
// swift-tools-version:5.9.2
22
//===----------------------------------------------------------------------===//
33
//
44
// This source file is part of the SwiftOpenAPIGenerator open source project
@@ -32,14 +32,6 @@ let package = Package(
3232
.product(name: "Hummingbird", package: "hummingbird"),
3333
],
3434
plugins: [.plugin(name: "OpenAPIGenerator", package: "swift-openapi-generator")]
35-
),
36-
.testTarget(
37-
name: "HelloWorldHummingbirdServerTests",
38-
dependencies: [
39-
"HelloWorldHummingbirdServer", .product(name: "OpenAPIRuntime", package: "swift-openapi-runtime"),
40-
.product(name: "OpenAPIHummingbird", package: "swift-openapi-hummingbird"),
41-
.product(name: "Hummingbird", package: "hummingbird"),
42-
]
43-
),
35+
), .testTarget(name: "HelloWorldHummingbirdServerTests", dependencies: ["HelloWorldHummingbirdServer"]),
4436
]
4537
)

Examples/hello-world-vapor-server-example/Package.swift

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// swift-tools-version:5.9
1+
// swift-tools-version:5.9.2
22
//===----------------------------------------------------------------------===//
33
//
44
// This source file is part of the SwiftOpenAPIGenerator open source project
@@ -32,14 +32,6 @@ let package = Package(
3232
.product(name: "Vapor", package: "vapor"),
3333
],
3434
plugins: [.plugin(name: "OpenAPIGenerator", package: "swift-openapi-generator")]
35-
),
36-
.testTarget(
37-
name: "HelloWorldVaporServerTests",
38-
dependencies: [
39-
"HelloWorldVaporServer", .product(name: "OpenAPIRuntime", package: "swift-openapi-runtime"),
40-
.product(name: "OpenAPIVapor", package: "swift-openapi-vapor"),
41-
.product(name: "Vapor", package: "vapor"),
42-
]
43-
),
35+
), .testTarget(name: "HelloWorldVaporServerTests", dependencies: ["HelloWorldVaporServer"]),
4436
]
4537
)

Examples/various-content-types-server-example/Package.swift

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// swift-tools-version:5.9
1+
// swift-tools-version:5.9.2
22
//===----------------------------------------------------------------------===//
33
//
44
// This source file is part of the SwiftOpenAPIGenerator open source project
@@ -32,14 +32,6 @@ let package = Package(
3232
.product(name: "Vapor", package: "vapor"),
3333
],
3434
plugins: [.plugin(name: "OpenAPIGenerator", package: "swift-openapi-generator")]
35-
),
36-
.testTarget(
37-
name: "ContentTypesServerTests",
38-
dependencies: [
39-
"ContentTypesServer", .product(name: "OpenAPIRuntime", package: "swift-openapi-runtime"),
40-
.product(name: "OpenAPIVapor", package: "swift-openapi-vapor"),
41-
.product(name: "Vapor", package: "vapor"),
42-
]
43-
),
35+
), .testTarget(name: "ContentTypesServerTests", dependencies: ["ContentTypesServer"]),
4436
]
4537
)

0 commit comments

Comments
 (0)