Update the implementation with the latest feedback on the proposal

Author: czechboy0

Sources/_OpenAPIGeneratorCore/Translator/CommonTranslations/SwiftSafeNames.swift

@@ -97,13 +97,15 @@ extension String {
 
         // 1. Leave leading underscores as-are
         // 2. In the middle: word separators: ["_", "-", <space>] -> remove and capitalize next word
-        // 3. In the middle: period: ["."] -> replace with "_"
+        // 3. In the middle: period: [".", "/"] -> replace with "_"
+        // 4. In the middle: drop ["{", "}"] -> replace with ""
 
         var buffer: [Character] = []
         buffer.reserveCapacity(count)
 
         enum State {
             case modifying
+            case fallback
             case preFirstWord
             case accumulatingWord
             case waitingForWordStarter
@@ -129,7 +131,7 @@ extension String {
                     state = .accumulatingWord
                 } else {
                     // Illegal character, fall back to the defensive strategy.
-                    return safeForSwiftCode_defensive(options: options)
+                    state = .fallback
                 }
             case .accumulatingWord:
                 if char.isLetter || char.isNumber {
@@ -139,22 +141,25 @@ extension String {
                         buffer.append(char)
                     }
                     state = .accumulatingWord
-                } else if char == "_" || char == "-" || char == " " {
+                } else if ["_", "-", " "].contains(char) {
                     // In the middle of an identifier, dashes, underscores, and spaces are considered
                     // word separators, so we remove the character and end the current word.
                     state = .waitingForWordStarter
-                } else if char == "." {
-                    // In the middle of an identifier, a period gets replaced with an underscore, but continues
-                    // the current word.
+                } else if [".", "/"].contains(char) {
+                    // In the middle of an identifier, a period or a slash gets replaced with
+                    // an underscore, but continues the current word.
                     buffer.append("_")
                     state = .accumulatingWord
+                } else if ["{", "}"].contains(char) {
+                    // In the middle of an identifier, curly braces are dropped.
+                    state = .accumulatingWord
                 } else {
                     // Illegal character, fall back to the defensive strategy.
-                    return safeForSwiftCode_defensive(options: options)
+                    state = .fallback
                 }
             case .waitingForWordStarter:
-                if char == "_" || char == "-" {
-                    // Between words, just drop dashes, underscores, and spaces, since
+                if ["_", "-", ".", "/", "{", "}"].contains(char) {
+                    // Between words, just drop allowed special characters, since
                     // we're already between words anyway.
                     state = .waitingForWordStarter
                 } else if char.isLetter || char.isNumber {
@@ -163,12 +168,15 @@ extension String {
                     state = .accumulatingWord
                 } else {
                     // Illegal character, fall back to the defensive strategy.
-                    return safeForSwiftCode_defensive(options: options)
+                    state = .fallback
                 }
-            case .modifying:
+            case .modifying, .fallback:
                 preconditionFailure("Logic error in \(#function), string: '\(self)'")
             }
             precondition(state != .modifying, "Logic error in \(#function), string: '\(self)'")
+            if case .fallback = state {
+                return safeForSwiftCode_defensive(options: options)
+            }
         }
         if buffer.isEmpty || state == .preFirstWord {
             return safeForSwiftCode_defensive(options: options)

Tests/OpenAPIGeneratorCoreTests/Extensions/Test_SwiftSafeNames.swift

@@ -39,17 +39,23 @@ final class Test_SwiftSafeNames: Test_Core {
             // Numbers
             ("version 2.0", "version_space_2_period_0", "Version2_0", "version2_0"),
             ("V1.2Release", "V1_period_2Release", "V1_2Release", "v1_2Release"),
-            
+
             // Synthesized operationId from method + path
             (
                 "get/pets/{petId}/notifications",
                 "get_sol_pets_sol__lcub_petId_rcub__sol_notifications",
-                "GetPetsPetIdNotifications",
-                "getPetsPetIdNotifications"
+                "Get_pets_petId_notifications",
+                "get_pets_petId_notifications",
             ),
-            
+            (
+                "get/name/v{version}.zip",
+                "get_sol_name_sol_v_lcub_version_rcub__period_zip",
+                "Get_name_vversion_zip",
+                "get_name_vversion_zip"
+            ),
+
             // Technical strings
-            ("file/path/to/resource", "file_sol_path_sol_to_sol_resource", "file_sol_path_sol_to_sol_resource", "file_sol_path_sol_to_sol_resource"),
+            ("file/path/to/resource", "file_sol_path_sol_to_sol_resource", "File_path_to_resource", "file_path_to_resource"),
             ("[email protected]", "user_period_name_commat_domain_period_com", "user_period_name_commat_domain_period_com", "user_period_name_commat_domain_period_com"),
             ("hello.world.2023", "hello_period_world_period_2023", "Hello_world_2023", "hello_world_2023"),
             ("order#123", "order_num_123", "order_num_123", "order_num_123"),