Skip to content

Enable strict concurrency #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2024
Merged

Enable strict concurrency #686

merged 1 commit into from
Dec 2, 2024

Conversation

@czechboy0
Copy link
Contributor

@czechboy0 czechboy0 commented Dec 2, 2024

Motivation:

Catch potential data races at build time.

Modifications:

  • Enabled unconditional strict concurrency complete checking.
  • Enabled warnings-as-errors on Swift 6 Linux pipelines.
  • Made a few fixes to be strict concurrency-clean.

Result:

Fewer potential data races can sneak in.

Test Plan

Ran tests locally, did not see any more warnings or errors.

@czechboy0 czechboy0 added the 🔨 semver/patch No public API change. label Dec 2, 2024
glbrntt
glbrntt approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@czechboy0 czechboy0 merged commit 1524989 into apple:main Dec 2, 2024
35 of 36 checks passed
@czechboy0 czechboy0 deleted the hd-strict-concurrency branch December 2, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glbrntt glbrntt glbrntt approved these changes

@simonjbeaumont simonjbeaumont Awaiting requested review from simonjbeaumont

Assignees

No one assigned

Labels

🔨 semver/patch No public API change.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@czechboy0 @glbrntt