Add a CLI option for selecting the naming strategy #708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjbeaumont
approved these changes
Jan 6, 2025
czechboy0
added a commit
that referenced
this pull request
Jan 6, 2025
…istent (#713) ### Motivation A missed fixup from #708: #708 (comment) ### Modifications Removed the default from Config.init and forced all callers to make a choice on the naming strategy, just like for accessModifier. ### Result Consistent handling of these two parameters. ### Test Plan Tests passed locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The recently introduced naming strategy is only configurable in the config file, but pure CLI users might also want to use it without creating a config file.
Modifications
Add a
--naming-strategyoption to theswift-openapi-generatorCLI.Result
Users can use the new naming strategy without creating a config file, if they didn't have one before.
Test Plan
Tested manually on a sample project.