Drop Swift 5.10 #834
Open
Drop Swift 5.10 #834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Swift 5.10 is no longer supported, we should bump the tools version and remove it from our CI. Modifications: * Bump the Swift tools version to Swift 6.0 * Remove Swift 5.10 jobs where appropriate in main.yml, pull_request.yml Result: Code reflects our support window.
Comment on lines
+24
to
+25
| // Use Swift 5 language mode until Swift 6.1 tools are the minimum version. | ||
| .swiftLanguageMode(.v5), |
There was a problem hiding this comment.
What's the reasoning behind this one?
There was a problem hiding this comment.
Concurrency errors that only showed up on 6.0 but work fine on 6.1+, as the compiler got smarter about things like sending patterns etc. So the code is safe, 6.0 just doesn't know that. Once 6.3 is out the problem will go away and we can move to Swift 6 mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Swift 5.10 is no longer supported, we should bump the tools version and remove it from our CI.
Modifications:
Result:
Code reflects our support window.