WIP on rewriting, doesn't build yet

Author: czechboy0

Sources/OpenAPIRuntime/Conversion/Converter+Server.swift

@@ -60,22 +60,41 @@ extension Converter {
         guard let parsedSubstring = OpenAPIMIMEType(substring) else {
             throw RuntimeError.invalidAcceptSubstring(substring)
         }
-        guard case .concrete(let substringType, let substringSubtype) = parsedSubstring.kind else {
-            // If the substring content type has a wildcard, just let it through.
-            // It's not well defined how such a case should behave, so be permissive.
-            return
-        }
-
         // Look for the first match.
         for acceptValue in acceptValues {
             // Fast path.
             if acceptValue == substring { return }
             guard let parsedAcceptValue = OpenAPIMIMEType(acceptValue) else {
                 throw RuntimeError.invalidExpectedContentType(acceptValue)
             }
-            switch parsedAcceptValue.kind {
-            case .any: return
-            case .anySubtype(type: let type): if substringType.lowercased() == type.lowercased() { return }
+            switch (parsedAcceptValue.kind, parsedSubstring.kind) {
+            case (.any, _):
+                // Accept: */* always matches
+                return
+            case (.anySubtype(type: let acceptType), let substring):
+                switch substring {
+                case .any:
+                    // */* as a concrete content type is NOT a match for an Accept header of foo/*
+                    break
+                case .anySubtype(type: let substringType):
+                    if substringType.lowercased() == acceptType.lowercased() {
+                        return
+                    }
+                case .concrete(type: let substringType, subtype: let substringSubtype):
+                    if
+                        substringType.lowercased() == acceptType.lowercased() &&
+                        
+                    {
+                        return
+                    }
+
+                    if accept.lowercased() == substringType.lowercased()
+                        && subtype.lowercased() == substringSubtype.lowercased()
+                    {
+                        return
+                    }
+                }
+                
             case .concrete(type: let type, subtype: let subtype):
                 if type.lowercased() == substringType.lowercased()
                     && subtype.lowercased() == substringSubtype.lowercased()

Tests/OpenAPIRuntimeTests/Conversion/Test_Converter+Server.swift

@@ -52,6 +52,7 @@ final class Test_ServerConverterExtensions: Test_Runtime {
 
             // Accept: text/plain, text/plain succeeds, application/json fails
             (short, "text/plain", true), (short, "application/json", false),
+            (short, "application/*", false), (short, "*/*", false),
 
             // A bunch of acceptable content types
             (long, "text/html", true), (long, "application/xhtml+xml", true), (long, "application/xml", true),