Skip to content

Commit 1bd5111

Browse files
committed
Prefix uses of Message with
1 parent d36b824 commit 1bd5111

23 files changed

+59
-59
lines changed

Sources/Conformance/main.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ func buildResponse(serializedBytes: [UInt8]) -> Conformance_ConformanceResponse
8484
return response
8585
}
8686

87-
let msgType: SwiftProtobuf.Message.Type
87+
let msgType: any SwiftProtobuf.Message.Type
8888
let extensions: SwiftProtobuf.ExtensionMap
8989
switch request.messageType {
9090
case "":
@@ -102,7 +102,7 @@ func buildResponse(serializedBytes: [UInt8]) -> Conformance_ConformanceResponse
102102
return response
103103
}
104104

105-
let testMessage: SwiftProtobuf.Message
105+
let testMessage: any SwiftProtobuf.Message
106106
switch request.payload {
107107
case .protobufPayload(let data)?:
108108
do {

Sources/SwiftProtobuf/AnyMessageStorage.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
import Foundation
1717

1818
fileprivate func serializeAnyJSON(
19-
for message: Message,
19+
for message: any Message,
2020
typeURL: String,
2121
options: JSONEncodingOptions
2222
) throws -> String {
@@ -33,7 +33,7 @@ fileprivate func serializeAnyJSON(
3333
return visitor.stringResult
3434
}
3535

36-
fileprivate func emitVerboseTextForm(visitor: inout TextFormatEncodingVisitor, message: Message, typeURL: String) {
36+
fileprivate func emitVerboseTextForm(visitor: inout TextFormatEncodingVisitor, message: any Message, typeURL: String) {
3737
let url: String
3838
if typeURL.isEmpty {
3939
url = buildTypeURL(forMessage: message, typePrefix: defaultAnyTypeURLPrefix)
@@ -55,7 +55,7 @@ fileprivate func asJSONObject(body: [UInt8]) -> Data {
5555
fileprivate func unpack(contentJSON: [UInt8],
5656
extensions: ExtensionMap,
5757
options: JSONDecodingOptions,
58-
as messageType: Message.Type) throws -> Message {
58+
as messageType: any Message.Type) throws -> any Message {
5959
guard messageType is _CustomJSONCodable.Type else {
6060
let contentJSONAsObject = asJSONObject(body: contentJSON)
6161
return try messageType.init(jsonUTF8Bytes: contentJSONAsObject, extensions: extensions, options: options)
@@ -135,7 +135,7 @@ internal class AnyMessageStorage {
135135
// unpacking that takes new options when a developer decides to decode it.
136136
case binary(Data)
137137
// a message
138-
case message(Message)
138+
case message(any Message)
139139
// parsed JSON with the @type removed and the decoding options.
140140
case contentJSON([UInt8], JSONDecodingOptions)
141141
}

Sources/SwiftProtobuf/BinaryDecoder.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1090,7 +1090,7 @@ internal struct BinaryDecoder: Decoder {
10901090

10911091
internal mutating func decodeExtensionField(
10921092
values: inout ExtensionFieldValueSet,
1093-
messageType: Message.Type,
1093+
messageType: any Message.Type,
10941094
fieldNumber: Int
10951095
) throws {
10961096
if let ext = extensions?[messageType, fieldNumber] {
@@ -1104,7 +1104,7 @@ internal struct BinaryDecoder: Decoder {
11041104
/// Helper to reuse between Extension decoding and MessageSet Extension decoding.
11051105
private mutating func decodeExtensionField(
11061106
values: inout ExtensionFieldValueSet,
1107-
messageType: Message.Type,
1107+
messageType: any Message.Type,
11081108
fieldNumber: Int,
11091109
messageExtension ext: AnyMessageExtension
11101110
) throws {
@@ -1131,7 +1131,7 @@ internal struct BinaryDecoder: Decoder {
11311131

11321132
internal mutating func decodeExtensionFieldsAsMessageSet(
11331133
values: inout ExtensionFieldValueSet,
1134-
messageType: Message.Type
1134+
messageType: any Message.Type
11351135
) throws {
11361136
// Spin looking for the Item group, everything else will end up in unknown fields.
11371137
while let fieldNumber = try self.nextFieldNumber() {
@@ -1175,7 +1175,7 @@ internal struct BinaryDecoder: Decoder {
11751175

11761176
private mutating func decodeMessageSetItem(
11771177
values: inout ExtensionFieldValueSet,
1178-
messageType: Message.Type
1178+
messageType: any Message.Type
11791179
) throws -> DecodeMessageSetItemResult {
11801180
// This is loosely based on the C++:
11811181
// ExtensionSet::ParseMessageSetItem()

Sources/SwiftProtobuf/BinaryDelimited.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public enum BinaryDelimited {
6565
/// `BinaryDelimited.Error` for some writing errors, or the
6666
/// underlying `OutputStream.streamError` for a stream error.
6767
public static func serialize(
68-
message: Message,
68+
message: any Message,
6969
to stream: OutputStream,
7070
partial: Bool = false
7171
) throws {

Sources/SwiftProtobuf/Decoder.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -204,11 +204,11 @@ public protocol Decoder {
204204
// Decode extension fields
205205

206206
/// Decode an extension field
207-
mutating func decodeExtensionField(values: inout ExtensionFieldValueSet, messageType: Message.Type, fieldNumber: Int) throws
207+
mutating func decodeExtensionField(values: inout ExtensionFieldValueSet, messageType: any Message.Type, fieldNumber: Int) throws
208208

209209
// Run a decode loop decoding the MessageSet format for Extensions.
210210
mutating func decodeExtensionFieldsAsMessageSet(values: inout ExtensionFieldValueSet,
211-
messageType: Message.Type) throws
211+
messageType: any Message.Type) throws
212212
}
213213

214214
/// Most Decoders won't care about Extension handing as in MessageSet
@@ -217,7 +217,7 @@ public protocol Decoder {
217217
extension Decoder {
218218
public mutating func decodeExtensionFieldsAsMessageSet(
219219
values: inout ExtensionFieldValueSet,
220-
messageType: Message.Type
220+
messageType: any Message.Type
221221
) throws {
222222
while let fieldNumber = try self.nextFieldNumber() {
223223
try self.decodeExtensionField(values: &values,

Sources/SwiftProtobuf/ExtensionMap.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
/// standard `SimpleExtensionMap` implementation.
2525
public protocol ExtensionMap: Sendable {
2626
/// Returns the extension object describing an extension or nil
27-
subscript(messageType: Message.Type, fieldNumber: Int) -> AnyMessageExtension? { get }
27+
subscript(messageType: any Message.Type, fieldNumber: Int) -> AnyMessageExtension? { get }
2828

2929
/// Returns the field number for a message with a specific field name
3030
///
@@ -34,5 +34,5 @@ public protocol ExtensionMap: Sendable {
3434
/// for the proto file and `message` is the name of the message in
3535
/// which the extension was defined. (This is different from the
3636
/// message that is being extended!)
37-
func fieldNumberForProto(messageType: Message.Type, protoFieldName: String) -> Int?
37+
func fieldNumberForProto(messageType: any Message.Type, protoFieldName: String) -> Int?
3838
}

Sources/SwiftProtobuf/Google_Protobuf_Any+Extensions.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ extension Google_Protobuf_Any {
3838
/// - Throws: `BinaryEncodingError.missingRequiredFields` if `partial` is
3939
/// false and `message` wasn't fully initialized.
4040
public init(
41-
message: Message,
41+
message: any Message,
4242
partial: Bool = false,
4343
typePrefix: String = defaultAnyTypeURLPrefix
4444
) throws {

Sources/SwiftProtobuf/Google_Protobuf_Any+Registry.swift

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ fileprivate let knownTypesQueue =
2626
// TODO: Should these first four be exposed as methods to go with
2727
// the general registry support?
2828

29-
internal func buildTypeURL(forMessage message: Message, typePrefix: String) -> String {
29+
internal func buildTypeURL(forMessage message: any Message, typePrefix: String) -> String {
3030
var url = typePrefix
3131
let needsSlash = typePrefix.isEmpty || typePrefix.last != "/"
3232
if needsSlash {
@@ -35,7 +35,7 @@ internal func buildTypeURL(forMessage message: Message, typePrefix: String) -> S
3535
return url + typeName(fromMessage: message)
3636
}
3737

38-
internal func typeName(fromMessage message: Message) -> String {
38+
internal func typeName(fromMessage message: any Message) -> String {
3939
let messageType = type(of: message)
4040
return messageType.protoMessageName
4141
}
@@ -67,7 +67,7 @@ fileprivate final class UnsafeMutableTransferBox<Wrapped> {
6767
extension UnsafeMutableTransferBox: @unchecked Sendable {}
6868

6969
// All access to this should be done on `knownTypesQueue`.
70-
fileprivate let knownTypes: UnsafeMutableTransferBox<[String:Message.Type]> = .init([
70+
fileprivate let knownTypes: UnsafeMutableTransferBox<[String: any Message.Type]> = .init([
7171
// Seeded with the Well Known Types.
7272
"google.protobuf.Any": Google_Protobuf_Any.self,
7373
"google.protobuf.BoolValue": Google_Protobuf_BoolValue.self,
@@ -117,7 +117,7 @@ extension Google_Protobuf_Any {
117117
///
118118
/// Returns: true if the type was registered, false if something
119119
/// else was already registered for the messageName.
120-
@discardableResult public static func register(messageType: Message.Type) -> Bool {
120+
@discardableResult public static func register(messageType: any Message.Type) -> Bool {
121121
let messageTypeName = messageType.protoMessageName
122122
var result: Bool = false
123123
execute(flags: .barrier) {
@@ -136,14 +136,14 @@ extension Google_Protobuf_Any {
136136
}
137137

138138
/// Returns the Message.Type expected for the given type URL.
139-
public static func messageType(forTypeURL url: String) -> Message.Type? {
139+
public static func messageType(forTypeURL url: String) -> (any Message.Type)? {
140140
let messageTypeName = typeName(fromURL: url)
141141
return messageType(forMessageName: messageTypeName)
142142
}
143143

144144
/// Returns the Message.Type expected for the given proto message name.
145-
public static func messageType(forMessageName name: String) -> Message.Type? {
146-
var result: Message.Type?
145+
public static func messageType(forMessageName name: String) -> (any Message.Type)? {
146+
var result: (any Message.Type)?
147147
execute(flags: .none) {
148148
result = knownTypes.wrappedValue[name]
149149
}

Sources/SwiftProtobuf/Internal.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public enum Internal {
2929

3030
/// Helper to loop over a list of Messages to see if they are all
3131
/// initialized (see Message.isInitialized for what that means).
32-
public static func areAllInitialized(_ listOfMessages: [Message]) -> Bool {
32+
public static func areAllInitialized(_ listOfMessages: [any Message]) -> Bool {
3333
for msg in listOfMessages {
3434
if !msg.isInitialized {
3535
return false
@@ -40,7 +40,7 @@ public enum Internal {
4040

4141
/// Helper to loop over dictionary with values that are Messages to see if
4242
/// they are all initialized (see Message.isInitialized for what that means).
43-
public static func areAllInitialized<K>(_ mapToMessages: [K: Message]) -> Bool {
43+
public static func areAllInitialized<K>(_ mapToMessages: [K: any Message]) -> Bool {
4444
for (_, msg) in mapToMessages {
4545
if !msg.isInitialized {
4646
return false

Sources/SwiftProtobuf/JSONDecoder.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import Foundation
1616

1717
internal struct JSONDecoder: Decoder {
1818
internal var scanner: JSONScanner
19-
internal var messageType: Message.Type
19+
internal var messageType: any Message.Type
2020
private var fieldCount = 0
2121
private var isMapKey = false
2222
private var fieldNameMap: _NameMap?
@@ -30,14 +30,14 @@ internal struct JSONDecoder: Decoder {
3030
}
3131

3232
internal init(source: UnsafeRawBufferPointer, options: JSONDecodingOptions,
33-
messageType: Message.Type, extensions: ExtensionMap?) {
33+
messageType: any Message.Type, extensions: ExtensionMap?) {
3434
let scanner = JSONScanner(source: source,
3535
options: options,
3636
extensions: extensions)
3737
self.init(scanner: scanner, messageType: messageType)
3838
}
3939

40-
private init(scanner: JSONScanner, messageType: Message.Type) {
40+
private init(scanner: JSONScanner, messageType: any Message.Type) {
4141
self.scanner = scanner
4242
self.messageType = messageType
4343
}
@@ -730,7 +730,7 @@ internal struct JSONDecoder: Decoder {
730730

731731
mutating func decodeExtensionField(
732732
values: inout ExtensionFieldValueSet,
733-
messageType: Message.Type,
733+
messageType: any Message.Type,
734734
fieldNumber: Int
735735
) throws {
736736
// Force-unwrap: we can only get here if the extension exists.

0 commit comments

Comments
 (0)