Use a Set for duplicate name checks.

thomasvl · thomasvl · commit 514b0d89a188 · 2023-10-26T09:39:37.000-04:00
If there are a lot files generated, this linear check could have become an
issue.
diff --git a/Sources/SwiftProtobufPluginLibrary/CodeGenerator.swift b/Sources/SwiftProtobufPluginLibrary/CodeGenerator.swift
@@ -250,11 +250,13 @@ private final class InternalGeneratorOutputs: GeneratorOutputs {
   }
 
   var files: [Google_Protobuf_Compiler_CodeGeneratorResponse.File] = []
+  private var fileNames: Set<String> = []
 
   func add(fileName: String, contents: String) throws {
-    guard !files.contains(where: { $0.name == fileName }) else {
+    guard !fileNames.contains(fileName) else {
       throw OutputError.duplicateName(fileName)
     }
+    fileNames.insert(fileName)
     files.append(
       Google_Protobuf_Compiler_CodeGeneratorResponse.File(
         name: fileName,

Original file line number	Diff line number	Diff line change
`@@ -250,11 +250,13 @@ private final class InternalGeneratorOutputs: GeneratorOutputs {`
`250`	`250`	`}`
`251`	`251`
`252`	`252`	`var files: [Google_Protobuf_Compiler_CodeGeneratorResponse.File] = []`
	`253`	`+ private var fileNames: Set<String> = []`
`253`	`254`
`254`	`255`	`func add(fileName: String, contents: String) throws {`
`255`		`- guard !files.contains(where: { $0.name == fileName }) else {`
	`256`	`+ guard !fileNames.contains(fileName) else {`
`256`	`257`	`throw OutputError.duplicateName(fileName)`
`257`	`258`	`}`
	`259`	`+ fileNames.insert(fileName)`
`258`	`260`	`files.append(`
`259`	`261`	`Google_Protobuf_Compiler_CodeGeneratorResponse.File(`
`260`	`262`	`name: fileName,`