Skip to content

Commit 60f88d0

Browse files
committed
Update upstream protos.
Using 991a2f4d54c6944396f55eaf13ae5248598ed28a from protobuf. Leaving off the file have been converted over to editions.
1 parent d0ef250 commit 60f88d0

File tree

5 files changed

+46
-38
lines changed

5 files changed

+46
-38
lines changed
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
syntax = "proto3";
2+
3+
package conformance;
4+
5+
// Temporary hack to allow the Rust conformance test to read the requested
6+
// output format as an int32. This will be removed once enums accessors are
7+
// supported. b/318373255
8+
message ConformanceRequestRustOverlayHack {
9+
int32 requested_output_format = 3;
10+
}

Protos/SwiftProtobuf/google/protobuf/descriptor.proto

Lines changed: 11 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,7 @@ message FileOptions {
484484
optional bool cc_generic_services = 16 [default = false];
485485
optional bool java_generic_services = 17 [default = false];
486486
optional bool py_generic_services = 18 [default = false];
487-
optional bool php_generic_services = 42 [default = false];
487+
reserved 42; // removed php_generic_services
488488

489489
// Is this file deprecated?
490490
// Depending on the target platform, this can emit Deprecated annotations
@@ -576,10 +576,6 @@ message MessageOptions {
576576

577577
reserved 4, 5, 6;
578578

579-
// NOTE: Do not set the option in .proto files. Always use the maps syntax
580-
// instead. The option should only be implicitly set by the proto compiler
581-
// parser.
582-
//
583579
// Whether the message is an automatically generated map entry type for the
584580
// maps field.
585581
//
@@ -597,6 +593,10 @@ message MessageOptions {
597593
// use a native map in the target language to hold the keys and values.
598594
// The reflection APIs in such implementations still need to work as
599595
// if the field is a repeated message field.
596+
//
597+
// NOTE: Do not set the option in .proto files. Always use the maps syntax
598+
// instead. The option should only be implicitly set by the proto compiler
599+
// parser.
600600
optional bool map_entry = 7;
601601

602602
reserved 8; // javalite_serializable
@@ -695,19 +695,11 @@ message FieldOptions {
695695
// call from multiple threads concurrently, while non-const methods continue
696696
// to require exclusive access.
697697
//
698-
// Note that implementations may choose not to check required fields within
699-
// a lazy sub-message. That is, calling IsInitialized() on the outer message
700-
// may return true even if the inner message has missing required fields.
701-
// This is necessary because otherwise the inner message would have to be
702-
// parsed in order to perform the check, defeating the purpose of lazy
703-
// parsing. An implementation which chooses not to check required fields
704-
// must be consistent about it. That is, for any particular sub-message, the
705-
// implementation must either *always* check its required fields, or *never*
706-
// check its required fields, regardless of whether or not the message has
707-
// been parsed.
708-
//
709-
// As of May 2022, lazy verifies the contents of the byte stream during
710-
// parsing. An invalid byte stream will cause the overall parsing to fail.
698+
// Note that lazy message fields are still eagerly verified to check
699+
// ill-formed wireformat or missing required fields. Calling IsInitialized()
700+
// on the outer message would fail if the inner message has missing required
701+
// fields. Failed verification would result in parsing failure (except when
702+
// uninitialized messages are acceptable).
711703
optional bool lazy = 5 [default = false];
712704

713705
// unverified_lazy does no correctness checks on the byte stream. This should
@@ -1104,7 +1096,7 @@ message SourceCodeInfo {
11041096
// location.
11051097
//
11061098
// Each element is a field number or an index. They form a path from
1107-
// the root FileDescriptorProto to the place where the definition occurs.
1099+
// the root FileDescriptorProto to the place where the definition appears.
11081100
// For example, this path:
11091101
// [ 4, 3, 2, 7, 1 ]
11101102
// refers to:
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
syntax = "proto3";
2+
3+
package conformance;
4+
5+
// Temporary hack to allow the Rust conformance test to read the requested
6+
// output format as an int32. This will be removed once enums accessors are
7+
// supported. b/318373255
8+
message ConformanceRequestRustOverlayHack {
9+
int32 requested_output_format = 3;
10+
}

Protos/upstream/google/protobuf/descriptor.proto

Lines changed: 11 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,7 @@ message FileOptions {
484484
optional bool cc_generic_services = 16 [default = false];
485485
optional bool java_generic_services = 17 [default = false];
486486
optional bool py_generic_services = 18 [default = false];
487-
optional bool php_generic_services = 42 [default = false];
487+
reserved 42; // removed php_generic_services
488488

489489
// Is this file deprecated?
490490
// Depending on the target platform, this can emit Deprecated annotations
@@ -576,10 +576,6 @@ message MessageOptions {
576576

577577
reserved 4, 5, 6;
578578

579-
// NOTE: Do not set the option in .proto files. Always use the maps syntax
580-
// instead. The option should only be implicitly set by the proto compiler
581-
// parser.
582-
//
583579
// Whether the message is an automatically generated map entry type for the
584580
// maps field.
585581
//
@@ -597,6 +593,10 @@ message MessageOptions {
597593
// use a native map in the target language to hold the keys and values.
598594
// The reflection APIs in such implementations still need to work as
599595
// if the field is a repeated message field.
596+
//
597+
// NOTE: Do not set the option in .proto files. Always use the maps syntax
598+
// instead. The option should only be implicitly set by the proto compiler
599+
// parser.
600600
optional bool map_entry = 7;
601601

602602
reserved 8; // javalite_serializable
@@ -695,19 +695,11 @@ message FieldOptions {
695695
// call from multiple threads concurrently, while non-const methods continue
696696
// to require exclusive access.
697697
//
698-
// Note that implementations may choose not to check required fields within
699-
// a lazy sub-message. That is, calling IsInitialized() on the outer message
700-
// may return true even if the inner message has missing required fields.
701-
// This is necessary because otherwise the inner message would have to be
702-
// parsed in order to perform the check, defeating the purpose of lazy
703-
// parsing. An implementation which chooses not to check required fields
704-
// must be consistent about it. That is, for any particular sub-message, the
705-
// implementation must either *always* check its required fields, or *never*
706-
// check its required fields, regardless of whether or not the message has
707-
// been parsed.
708-
//
709-
// As of May 2022, lazy verifies the contents of the byte stream during
710-
// parsing. An invalid byte stream will cause the overall parsing to fail.
698+
// Note that lazy message fields are still eagerly verified to check
699+
// ill-formed wireformat or missing required fields. Calling IsInitialized()
700+
// on the outer message would fail if the inner message has missing required
701+
// fields. Failed verification would result in parsing failure (except when
702+
// uninitialized messages are acceptable).
711703
optional bool lazy = 5 [default = false];
712704

713705
// unverified_lazy does no correctness checks on the byte stream. This should
@@ -1104,7 +1096,7 @@ message SourceCodeInfo {
11041096
// location.
11051097
//
11061098
// Each element is a field number or an index. They form a path from
1107-
// the root FileDescriptorProto to the place where the definition occurs.
1099+
// the root FileDescriptorProto to the place where the definition appears.
11081100
// For example, this path:
11091101
// [ 4, 3, 2, 7, 1 ]
11101102
// refers to:

Protos/upstream/google/protobuf/map_unittest.proto

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,3 +101,7 @@ message MessageContainingMapCalledEntry {
101101
message TestRecursiveMapMessage {
102102
map<string, TestRecursiveMapMessage> a = 1;
103103
}
104+
105+
message TestI32StrMap {
106+
map<int32, string> m_32_str = 1;
107+
}

0 commit comments

Comments
 (0)