Skip to content

Commit 683e459

Browse files
authored
Update protos file, generated files, and record a new conformance test failure. (#1753)
1 parent 4f6e091 commit 683e459

File tree

106 files changed

+25293
-20095
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

106 files changed

+25293
-20095
lines changed

Protos/Conformance/editions/test_messages_proto2_editions.proto

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -316,6 +316,8 @@ message TestAllTypesProto2 {
316316
// Reserved for unknown fields test.
317317
reserved 1000 to 9999;
318318

319+
MessageSetCorrect message_set_correct = 500;
320+
319321
// message_set test case.
320322
message MessageSetCorrect {
321323
option message_set_wire_format = true;
@@ -338,6 +340,17 @@ message TestAllTypesProto2 {
338340

339341
int32 i = 9;
340342
}
343+
344+
message ExtensionWithOneof {
345+
oneof oneof_field {
346+
int32 a = 1;
347+
int32 b = 2;
348+
}
349+
350+
extend MessageSetCorrect {
351+
ExtensionWithOneof extension_with_oneof = 123456789;
352+
}
353+
}
341354
}
342355

343356
message ForeignMessageProto2 {
@@ -640,3 +653,28 @@ message TestAllRequiredTypesProto2 {
640653
];
641654
}
642655
}
656+
657+
message TestLargeOneof {
658+
message A1 {
659+
}
660+
661+
message A2 {
662+
}
663+
664+
message A3 {
665+
}
666+
667+
message A4 {
668+
}
669+
670+
message A5 {
671+
}
672+
673+
oneof large_oneof {
674+
A1 a1 = 1;
675+
A2 a2 = 2;
676+
A3 a3 = 3;
677+
A4 a4 = 4;
678+
A5 a5 = 5;
679+
}
680+
}

Protos/Conformance/google/protobuf/test_messages_proto2.proto

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,8 @@ message TestAllTypesProto2 {
219219
// Reserved for unknown fields test.
220220
reserved 1000 to 9999;
221221

222+
optional MessageSetCorrect message_set_correct = 500;
223+
222224
// message_set test case.
223225
message MessageSetCorrect {
224226
option message_set_wire_format = true;
@@ -239,6 +241,16 @@ message TestAllTypesProto2 {
239241
}
240242
optional int32 i = 9;
241243
}
244+
245+
message ExtensionWithOneof {
246+
oneof oneof_field {
247+
int32 a = 1;
248+
int32 b = 2;
249+
}
250+
extend MessageSetCorrect {
251+
optional ExtensionWithOneof extension_with_oneof = 123456789;
252+
}
253+
}
242254
}
243255

244256
message ForeignMessageProto2 {
@@ -385,3 +397,18 @@ message TestAllRequiredTypesProto2 {
385397
required int32 i = 9;
386398
}
387399
}
400+
401+
message TestLargeOneof {
402+
message A1 {}
403+
message A2 {}
404+
message A3 {}
405+
message A4 {}
406+
message A5 {}
407+
oneof large_oneof {
408+
A1 a1 = 1;
409+
A2 a2 = 2;
410+
A3 a3 = 3;
411+
A4 a4 = 4;
412+
A5 a5 = 5;
413+
}
414+
}

Protos/SwiftProtobuf/google/protobuf/descriptor.proto

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1098,6 +1098,29 @@ message FeatureSet {
10981098
edition_defaults = { edition: EDITION_PROTO3, value: "ALLOW" }
10991099
];
11001100

1101+
enum EnforceNamingStyle {
1102+
ENFORCE_NAMING_STYLE_UNKNOWN = 0;
1103+
STYLE2024 = 1;
1104+
STYLE_LEGACY = 2;
1105+
}
1106+
optional EnforceNamingStyle enforce_naming_style = 7 [
1107+
retention = RETENTION_SOURCE,
1108+
targets = TARGET_TYPE_FILE,
1109+
targets = TARGET_TYPE_EXTENSION_RANGE,
1110+
targets = TARGET_TYPE_MESSAGE,
1111+
targets = TARGET_TYPE_FIELD,
1112+
targets = TARGET_TYPE_ONEOF,
1113+
targets = TARGET_TYPE_ENUM,
1114+
targets = TARGET_TYPE_ENUM_ENTRY,
1115+
targets = TARGET_TYPE_SERVICE,
1116+
targets = TARGET_TYPE_METHOD,
1117+
feature_support = {
1118+
edition_introduced: EDITION_2024,
1119+
},
1120+
edition_defaults = { edition: EDITION_LEGACY, value: "STYLE_LEGACY" },
1121+
edition_defaults = { edition: EDITION_2024, value: "STYLE2024" }
1122+
];
1123+
11011124
reserved 999;
11021125

11031126
extensions 1000 to 9994 [

0 commit comments

Comments
 (0)