Merge pull request #1499 from tbkka/tbkka-large-oss-fuzz-example

A performance-oriented test decoding 1 million messages from a stream

Author: tbkka

FuzzTesting/FailCases/clusterfuzz-testcase-minimized-FuzzAsyncMessageSequence_debug-5217919734513664

@@ -199,6 +199,26 @@ final class Test_AsyncMessageSequence: XCTestCase {
     }
     XCTAssertTrue(truncatedThrown, "Should throw a BinaryDelimited.Error.truncated")
   }
+
+  // Slow test case found by oss-fuzz: 1 million zero-sized messages
+  // A similar test with BinaryDelimited is about 4x faster, showing
+  // that we have some room for improvement here.
+  // (Note this currently only tests 100,000 zero-sized messages,
+  // but the constant below is easy to edit if you want to experiment.)
+  func testLargeExample() async throws {
+    let messageCount = 100_000
+    let bytes = [UInt8](repeating: 0, count: messageCount)
+    let byteStream = asyncByteStream(bytes: bytes)
+    let decodedStream = byteStream.binaryProtobufDelimitedMessages(
+                    of: SwiftProtoTesting_TestAllTypes.self,
+                    extensions: SwiftProtoTesting_Fuzz_FuzzTesting_Extensions)
+    var count = 0
+    for try await message in decodedStream {
+      XCTAssertEqual(message, SwiftProtoTesting_TestAllTypes())
+      count += 1
+    }
+    XCTAssertEqual(count, messageCount)
+  }
 
   fileprivate func asyncByteStream(bytes: [UInt8]) -> AsyncStream<UInt8> {
       AsyncStream(UInt8.self) { continuation in

Tests/SwiftProtobufTests/Test_AsyncMessageSequence.swift

@@ -145,4 +145,21 @@ final class Test_BinaryDelimited: XCTestCase {
     assertParseFails(atEndOfStream: stream2)
   }
 
+  // oss-fuzz found this case that runs slowly for AsyncMessageSequence
+  // Copied here as well for comparison.
+  func testLargeExample() throws {
+    let messageCount = 100_000
+    let bytes = [UInt8](repeating: 0, count: messageCount)
+    let istream = openInputStream(bytes)
+
+    for _ in 0..<messageCount {
+      let msg = try BinaryDelimited.parse(
+	messageType: SwiftProtoTesting_TestAllTypes.self,
+	from: istream)
+      XCTAssertEqual(msg, SwiftProtoTesting_TestAllTypes())
+    }
+    XCTAssertThrowsError(try BinaryDelimited.parse(
+	messageType: SwiftProtoTesting_TestAllTypes.self,
+	from: istream))
+  }
 }