Remove unused Visitor var

Author: mrabiciu

Protos/SwiftProtobufTests/generated_swift_names_enum_cases.proto

@@ -893,77 +893,76 @@ enum GeneratedSwiftReservedEnum {
   VerificationState = 886;
   Version = 887;
   versionString = 888;
-  visitDefaultValues = 889;
-  visitExtensionFields = 890;
-  visitExtensionFieldsAsMessageSet = 891;
-  visitMapField = 892;
-  visitor = 893;
-  visitPacked = 894;
-  visitPackedBoolField = 895;
-  visitPackedDoubleField = 896;
-  visitPackedEnumField = 897;
-  visitPackedFixed32Field = 898;
-  visitPackedFixed64Field = 899;
-  visitPackedFloatField = 900;
-  visitPackedInt32Field = 901;
-  visitPackedInt64Field = 902;
-  visitPackedSFixed32Field = 903;
-  visitPackedSFixed64Field = 904;
-  visitPackedSInt32Field = 905;
-  visitPackedSInt64Field = 906;
-  visitPackedUInt32Field = 907;
-  visitPackedUInt64Field = 908;
-  visitRepeated = 909;
-  visitRepeatedBoolField = 910;
-  visitRepeatedBytesField = 911;
-  visitRepeatedDoubleField = 912;
-  visitRepeatedEnumField = 913;
-  visitRepeatedFixed32Field = 914;
-  visitRepeatedFixed64Field = 915;
-  visitRepeatedFloatField = 916;
-  visitRepeatedGroupField = 917;
-  visitRepeatedInt32Field = 918;
-  visitRepeatedInt64Field = 919;
-  visitRepeatedMessageField = 920;
-  visitRepeatedSFixed32Field = 921;
-  visitRepeatedSFixed64Field = 922;
-  visitRepeatedSInt32Field = 923;
-  visitRepeatedSInt64Field = 924;
-  visitRepeatedStringField = 925;
-  visitRepeatedUInt32Field = 926;
-  visitRepeatedUInt64Field = 927;
-  visitSingular = 928;
-  visitSingularBoolField = 929;
-  visitSingularBytesField = 930;
-  visitSingularDoubleField = 931;
-  visitSingularEnumField = 932;
-  visitSingularFixed32Field = 933;
-  visitSingularFixed64Field = 934;
-  visitSingularFloatField = 935;
-  visitSingularGroupField = 936;
-  visitSingularInt32Field = 937;
-  visitSingularInt64Field = 938;
-  visitSingularMessageField = 939;
-  visitSingularSFixed32Field = 940;
-  visitSingularSFixed64Field = 941;
-  visitSingularSInt32Field = 942;
-  visitSingularSInt64Field = 943;
-  visitSingularStringField = 944;
-  visitSingularUInt32Field = 945;
-  visitSingularUInt64Field = 946;
-  visitUnknown = 947;
-  wasDecoded = 948;
-  weak = 949;
-  weakDependency = 950;
-  where = 951;
-  wireFormat = 952;
-  with = 953;
-  withUnsafeBytes = 954;
-  withUnsafeMutableBytes = 955;
-  work = 956;
-  Wrapped = 957;
-  WrappedType = 958;
-  wrappedValue = 959;
-  written = 960;
-  yday = 961;
+  visitExtensionFields = 889;
+  visitExtensionFieldsAsMessageSet = 890;
+  visitMapField = 891;
+  visitor = 892;
+  visitPacked = 893;
+  visitPackedBoolField = 894;
+  visitPackedDoubleField = 895;
+  visitPackedEnumField = 896;
+  visitPackedFixed32Field = 897;
+  visitPackedFixed64Field = 898;
+  visitPackedFloatField = 899;
+  visitPackedInt32Field = 900;
+  visitPackedInt64Field = 901;
+  visitPackedSFixed32Field = 902;
+  visitPackedSFixed64Field = 903;
+  visitPackedSInt32Field = 904;
+  visitPackedSInt64Field = 905;
+  visitPackedUInt32Field = 906;
+  visitPackedUInt64Field = 907;
+  visitRepeated = 908;
+  visitRepeatedBoolField = 909;
+  visitRepeatedBytesField = 910;
+  visitRepeatedDoubleField = 911;
+  visitRepeatedEnumField = 912;
+  visitRepeatedFixed32Field = 913;
+  visitRepeatedFixed64Field = 914;
+  visitRepeatedFloatField = 915;
+  visitRepeatedGroupField = 916;
+  visitRepeatedInt32Field = 917;
+  visitRepeatedInt64Field = 918;
+  visitRepeatedMessageField = 919;
+  visitRepeatedSFixed32Field = 920;
+  visitRepeatedSFixed64Field = 921;
+  visitRepeatedSInt32Field = 922;
+  visitRepeatedSInt64Field = 923;
+  visitRepeatedStringField = 924;
+  visitRepeatedUInt32Field = 925;
+  visitRepeatedUInt64Field = 926;
+  visitSingular = 927;
+  visitSingularBoolField = 928;
+  visitSingularBytesField = 929;
+  visitSingularDoubleField = 930;
+  visitSingularEnumField = 931;
+  visitSingularFixed32Field = 932;
+  visitSingularFixed64Field = 933;
+  visitSingularFloatField = 934;
+  visitSingularGroupField = 935;
+  visitSingularInt32Field = 936;
+  visitSingularInt64Field = 937;
+  visitSingularMessageField = 938;
+  visitSingularSFixed32Field = 939;
+  visitSingularSFixed64Field = 940;
+  visitSingularSInt32Field = 941;
+  visitSingularSInt64Field = 942;
+  visitSingularStringField = 943;
+  visitSingularUInt32Field = 944;
+  visitSingularUInt64Field = 945;
+  visitUnknown = 946;
+  wasDecoded = 947;
+  weak = 948;
+  weakDependency = 949;
+  where = 950;
+  wireFormat = 951;
+  with = 952;
+  withUnsafeBytes = 953;
+  withUnsafeMutableBytes = 954;
+  work = 955;
+  Wrapped = 956;
+  WrappedType = 957;
+  wrappedValue = 958;
+  written = 959;
+  yday = 960;
 }

Protos/SwiftProtobufTests/generated_swift_names_enums.proto

@@ -892,7 +892,6 @@ message GeneratedSwiftReservedEnums {
   enum VerificationState { NONE_VerificationState = 0; }
   enum Version { NONE_Version = 0; }
   enum versionString { NONE_versionString = 0; }
-  enum visitDefaultValues { NONE_visitDefaultValues = 0; }
   enum visitExtensionFields { NONE_visitExtensionFields = 0; }
   enum visitExtensionFieldsAsMessageSet { NONE_visitExtensionFieldsAsMessageSet = 0; }
   enum visitMapField { NONE_visitMapField = 0; }

Protos/SwiftProtobufTests/generated_swift_names_fields.proto

@@ -892,77 +892,76 @@ message GeneratedSwiftReservedFields {
   int32 VerificationState = 886;
   int32 Version = 887;
   int32 versionString = 888;
-  int32 visitDefaultValues = 889;
-  int32 visitExtensionFields = 890;
-  int32 visitExtensionFieldsAsMessageSet = 891;
-  int32 visitMapField = 892;
-  int32 visitor = 893;
-  int32 visitPacked = 894;
-  int32 visitPackedBoolField = 895;
-  int32 visitPackedDoubleField = 896;
-  int32 visitPackedEnumField = 897;
-  int32 visitPackedFixed32Field = 898;
-  int32 visitPackedFixed64Field = 899;
-  int32 visitPackedFloatField = 900;
-  int32 visitPackedInt32Field = 901;
-  int32 visitPackedInt64Field = 902;
-  int32 visitPackedSFixed32Field = 903;
-  int32 visitPackedSFixed64Field = 904;
-  int32 visitPackedSInt32Field = 905;
-  int32 visitPackedSInt64Field = 906;
-  int32 visitPackedUInt32Field = 907;
-  int32 visitPackedUInt64Field = 908;
-  int32 visitRepeated = 909;
-  int32 visitRepeatedBoolField = 910;
-  int32 visitRepeatedBytesField = 911;
-  int32 visitRepeatedDoubleField = 912;
-  int32 visitRepeatedEnumField = 913;
-  int32 visitRepeatedFixed32Field = 914;
-  int32 visitRepeatedFixed64Field = 915;
-  int32 visitRepeatedFloatField = 916;
-  int32 visitRepeatedGroupField = 917;
-  int32 visitRepeatedInt32Field = 918;
-  int32 visitRepeatedInt64Field = 919;
-  int32 visitRepeatedMessageField = 920;
-  int32 visitRepeatedSFixed32Field = 921;
-  int32 visitRepeatedSFixed64Field = 922;
-  int32 visitRepeatedSInt32Field = 923;
-  int32 visitRepeatedSInt64Field = 924;
-  int32 visitRepeatedStringField = 925;
-  int32 visitRepeatedUInt32Field = 926;
-  int32 visitRepeatedUInt64Field = 927;
-  int32 visitSingular = 928;
-  int32 visitSingularBoolField = 929;
-  int32 visitSingularBytesField = 930;
-  int32 visitSingularDoubleField = 931;
-  int32 visitSingularEnumField = 932;
-  int32 visitSingularFixed32Field = 933;
-  int32 visitSingularFixed64Field = 934;
-  int32 visitSingularFloatField = 935;
-  int32 visitSingularGroupField = 936;
-  int32 visitSingularInt32Field = 937;
-  int32 visitSingularInt64Field = 938;
-  int32 visitSingularMessageField = 939;
-  int32 visitSingularSFixed32Field = 940;
-  int32 visitSingularSFixed64Field = 941;
-  int32 visitSingularSInt32Field = 942;
-  int32 visitSingularSInt64Field = 943;
-  int32 visitSingularStringField = 944;
-  int32 visitSingularUInt32Field = 945;
-  int32 visitSingularUInt64Field = 946;
-  int32 visitUnknown = 947;
-  int32 wasDecoded = 948;
-  int32 weak = 949;
-  int32 weakDependency = 950;
-  int32 where = 951;
-  int32 wireFormat = 952;
-  int32 with = 953;
-  int32 withUnsafeBytes = 954;
-  int32 withUnsafeMutableBytes = 955;
-  int32 work = 956;
-  int32 Wrapped = 957;
-  int32 WrappedType = 958;
-  int32 wrappedValue = 959;
-  int32 written = 960;
-  int32 yday = 961;
+  int32 visitExtensionFields = 889;
+  int32 visitExtensionFieldsAsMessageSet = 890;
+  int32 visitMapField = 891;
+  int32 visitor = 892;
+  int32 visitPacked = 893;
+  int32 visitPackedBoolField = 894;
+  int32 visitPackedDoubleField = 895;
+  int32 visitPackedEnumField = 896;
+  int32 visitPackedFixed32Field = 897;
+  int32 visitPackedFixed64Field = 898;
+  int32 visitPackedFloatField = 899;
+  int32 visitPackedInt32Field = 900;
+  int32 visitPackedInt64Field = 901;
+  int32 visitPackedSFixed32Field = 902;
+  int32 visitPackedSFixed64Field = 903;
+  int32 visitPackedSInt32Field = 904;
+  int32 visitPackedSInt64Field = 905;
+  int32 visitPackedUInt32Field = 906;
+  int32 visitPackedUInt64Field = 907;
+  int32 visitRepeated = 908;
+  int32 visitRepeatedBoolField = 909;
+  int32 visitRepeatedBytesField = 910;
+  int32 visitRepeatedDoubleField = 911;
+  int32 visitRepeatedEnumField = 912;
+  int32 visitRepeatedFixed32Field = 913;
+  int32 visitRepeatedFixed64Field = 914;
+  int32 visitRepeatedFloatField = 915;
+  int32 visitRepeatedGroupField = 916;
+  int32 visitRepeatedInt32Field = 917;
+  int32 visitRepeatedInt64Field = 918;
+  int32 visitRepeatedMessageField = 919;
+  int32 visitRepeatedSFixed32Field = 920;
+  int32 visitRepeatedSFixed64Field = 921;
+  int32 visitRepeatedSInt32Field = 922;
+  int32 visitRepeatedSInt64Field = 923;
+  int32 visitRepeatedStringField = 924;
+  int32 visitRepeatedUInt32Field = 925;
+  int32 visitRepeatedUInt64Field = 926;
+  int32 visitSingular = 927;
+  int32 visitSingularBoolField = 928;
+  int32 visitSingularBytesField = 929;
+  int32 visitSingularDoubleField = 930;
+  int32 visitSingularEnumField = 931;
+  int32 visitSingularFixed32Field = 932;
+  int32 visitSingularFixed64Field = 933;
+  int32 visitSingularFloatField = 934;
+  int32 visitSingularGroupField = 935;
+  int32 visitSingularInt32Field = 936;
+  int32 visitSingularInt64Field = 937;
+  int32 visitSingularMessageField = 938;
+  int32 visitSingularSFixed32Field = 939;
+  int32 visitSingularSFixed64Field = 940;
+  int32 visitSingularSInt32Field = 941;
+  int32 visitSingularSInt64Field = 942;
+  int32 visitSingularStringField = 943;
+  int32 visitSingularUInt32Field = 944;
+  int32 visitSingularUInt64Field = 945;
+  int32 visitUnknown = 946;
+  int32 wasDecoded = 947;
+  int32 weak = 948;
+  int32 weakDependency = 949;
+  int32 where = 950;
+  int32 wireFormat = 951;
+  int32 with = 952;
+  int32 withUnsafeBytes = 953;
+  int32 withUnsafeMutableBytes = 954;
+  int32 work = 955;
+  int32 Wrapped = 956;
+  int32 WrappedType = 957;
+  int32 wrappedValue = 958;
+  int32 written = 959;
+  int32 yday = 960;
 }

Protos/SwiftProtobufTests/generated_swift_names_messages.proto

@@ -892,7 +892,6 @@ message GeneratedSwiftReservedMessages {
   message VerificationState { int32 VerificationState = 1; }
   message Version { int32 Version = 1; }
   message versionString { int32 versionString = 1; }
-  message visitDefaultValues { int32 visitDefaultValues = 1; }
   message visitExtensionFields { int32 visitExtensionFields = 1; }
   message visitExtensionFieldsAsMessageSet { int32 visitExtensionFieldsAsMessageSet = 1; }
   message visitMapField { int32 visitMapField = 1; }

Sources/SwiftProtobuf/Visitor.swift

@@ -461,10 +461,6 @@ public struct TraversalOptions {
   /// - singular message and group fields: Will be visited only if they are set.
   /// - singular primitive fields: Will always be visited under proto2. Under proto3 unset optional primitive fields will not be visited.
   public var alwaysVisitPrimitiveFields: Bool
-    
-    public var visitDefaultValues: Bool {
-        alwaysVisitPrimitiveFields
-    }
 
   public init(alwaysVisitPrimitiveFields: Bool = false) {
     self.alwaysVisitPrimitiveFields = alwaysVisitPrimitiveFields