Skip to content

Commit eedb785

Browse files
author
Pouya Yarandi
committed
Fix comments
1 parent 787957f commit eedb785

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

Sources/SwiftProtobuf/Message+FieldMask.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ extension Message {
5656
/// - source: Message should be merged to the original one.
5757
/// - fieldMask: FieldMask specifies which fields should be merged.
5858
public mutating func merge(
59-
to source: Self,
59+
from source: Self,
6060
fieldMask: Google_Protobuf_FieldMask,
6161
mergeOption: MergeOption = .init()
6262
) throws {
@@ -96,7 +96,7 @@ extension Message where Self: Equatable, Self: _ProtoNameProviding {
9696
}
9797
var tmp = Self(removingAllFieldsOf: self)
9898
do {
99-
try tmp.merge(to: self, fieldMask: fieldMask)
99+
try tmp.merge(from: self, fieldMask: fieldMask)
100100
let changed = tmp != self
101101
self = tmp
102102
return changed

Sources/SwiftProtobuf/SetPathDecoder.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,10 @@ struct SetPathDecoder<T: Message>: Decoder {
6666
if let firstComponent = path.first,
6767
let number = T.number(for: firstComponent) {
6868
self.number = number
69+
self.nextPath = .init(path.dropFirst())
70+
} else {
71+
self.nextPath = []
6972
}
70-
self.nextPath = .init(path.dropFirst())
7173
self.value = value
7274
self.mergeOption = mergeOption
7375
}

Tests/SwiftProtobufTests/Test_FieldMask.swift

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,12 +124,12 @@ final class Test_FieldMask: XCTestCase, PBTestHelpers {
124124
}
125125

126126
// Checks nested message merge
127-
try message.merge(to: secondMessage, fieldMask: .init(protoPaths: "optional_nested_message.bb"))
127+
try message.merge(from: secondMessage, fieldMask: .init(protoPaths: "optional_nested_message.bb"))
128128
XCTAssertEqual(message.optionalInt32, 1)
129129
XCTAssertEqual(message.optionalNestedMessage.bb, 3)
130130

131131
// Checks primitive type merge
132-
try message.merge(to: secondMessage, fieldMask: .init(protoPaths: "optional_int32"))
132+
try message.merge(from: secondMessage, fieldMask: .init(protoPaths: "optional_int32"))
133133
XCTAssertEqual(message.optionalInt32, 2)
134134
XCTAssertEqual(message.optionalNestedMessage.bb, 3)
135135
}
@@ -147,11 +147,11 @@ final class Test_FieldMask: XCTestCase, PBTestHelpers {
147147
let fieldMask = Google_Protobuf_FieldMask(protoPaths: ["repeated_int32"])
148148

149149
// Checks without replacing repeated fields
150-
try message.merge(to: secondMessage, fieldMask: fieldMask)
150+
try message.merge(from: secondMessage, fieldMask: fieldMask)
151151
XCTAssertEqual(message.repeatedInt32, [1, 2, 3, 4])
152152

153153
// Checks with replacing repeated fields
154-
try message.merge(to: secondMessage, fieldMask: fieldMask, mergeOption: .init(replaceRepeatedFields: true))
154+
try message.merge(from: secondMessage, fieldMask: fieldMask, mergeOption: .init(replaceRepeatedFields: true))
155155
XCTAssertEqual(message.repeatedInt32, [3, 4])
156156
}
157157

@@ -168,11 +168,11 @@ final class Test_FieldMask: XCTestCase, PBTestHelpers {
168168
let fieldMask = Google_Protobuf_FieldMask(protoPaths: ["map_int32_string"])
169169

170170
// Checks without replacing repeated fields
171-
try message.merge(to: secondMessage, fieldMask: fieldMask)
171+
try message.merge(from: secondMessage, fieldMask: fieldMask)
172172
XCTAssertEqual(message.mapInt32String, [1: "a", 2: "b"])
173173

174174
// Checks with replacing repeated fields
175-
try message.merge(to: secondMessage, fieldMask: fieldMask, mergeOption: .init(replaceRepeatedFields: true))
175+
try message.merge(from: secondMessage, fieldMask: fieldMask, mergeOption: .init(replaceRepeatedFields: true))
176176
XCTAssertEqual(message.mapInt32String, [2: "b"])
177177
}
178178

0 commit comments

Comments
 (0)