Inline some of the parameter string parsing.

Author: thomasvl

Sources/SwiftProtobufPluginLibrary/CodeGenerator.swift

@@ -107,9 +107,16 @@ struct InternalCodeGeneratorParameter: CodeGeneratorParameter {
       return []
     }
     let parts = parameter.components(separatedBy: ",")
-    let asPairs = parts.map { partition(string: $0, atFirstOccurrenceOf: "=") }
-    let result = asPairs.map { (key: trimWhitespace($0), value: trimWhitespace($1)) }
-    return result
+    return parts.map { s -> (key: String, value: String) in
+      guard let index = s.range(of: "=")?.lowerBound else {
+        // Key only, no value ("baz" in example).
+        return (trimWhitespace(s), "")
+      }
+      return (
+        key: trimWhitespace(s[..<index]),
+        value: trimWhitespace(s[s.index(after: index)...])
+      )
+    }
   }
 }
 

Sources/SwiftProtobufPluginLibrary/StringUtils.swift

@@ -10,14 +10,12 @@
 
 import Foundation
 
-func partition(string: String, atFirstOccurrenceOf substring: String) -> (String, String) {
-  guard let index = string.range(of: substring)?.lowerBound else {
-    return (string, "")
-  }
-  return (String(string[..<index]),
-          String(string[string.index(after: index)...]))
+@inlinable
+func trimWhitespace(_ s: String) -> String {
+  return s.trimmingCharacters(in: .whitespacesAndNewlines)
 }
 
-func trimWhitespace(_ s: String) -> String {
+@inlinable
+func trimWhitespace(_ s: String.SubSequence) -> String {
   return s.trimmingCharacters(in: .whitespacesAndNewlines)
 }