[PlaygroundLogger] Added support for logging CGFloat instances as their native type.

This represents an enhancement over the previous logger, which did not handle CGFloat instances specially at all.

This addresses <rdar://problem/37421663>.

Author: cwakamo

PlaygroundLogger/PlaygroundLogger.xcodeproj/project.pbxproj

@@ -76,6 +76,7 @@
 		5E4AF1AF1FDDC12A00B7C9D9 /* LegacyEntrypoints.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5E4AF1AE1FDDC12A00B7C9D9 /* LegacyEntrypoints.swift */; };
 		5E5FE50B202D13C800E28C3C /* PGLConcurrentMap.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5E5FE50A202D13C800E28C3C /* PGLConcurrentMap.swift */; };
 		5ECE8F911FFCD2A70034D9BC /* LegacyPlaygroundLoggerTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5ECE8F901FFCD2A70034D9BC /* LegacyPlaygroundLoggerTests.swift */; };
+		5EE3867420352F3200D625F0 /* CGFloat+CustomOpaqueLoggable.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5EE3867320352F3200D625F0 /* CGFloat+CustomOpaqueLoggable.swift */; };
 /* End PBXBuildFile section */
 
 /* Begin PBXContainerItemProxy section */
@@ -161,6 +162,7 @@
 		5E4AF1AE1FDDC12A00B7C9D9 /* LegacyEntrypoints.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = LegacyEntrypoints.swift; sourceTree = "<group>"; };
 		5E5FE50A202D13C800E28C3C /* PGLConcurrentMap.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PGLConcurrentMap.swift; sourceTree = "<group>"; };
 		5ECE8F901FFCD2A70034D9BC /* LegacyPlaygroundLoggerTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = LegacyPlaygroundLoggerTests.swift; sourceTree = "<group>"; };
+		5EE3867320352F3200D625F0 /* CGFloat+CustomOpaqueLoggable.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "CGFloat+CustomOpaqueLoggable.swift"; sourceTree = "<group>"; };
 /* End PBXFileReference section */
 
 /* Begin PBXFrameworksBuildPhase section */
@@ -375,6 +377,7 @@
 				5E27566D1FC51F7E00B69C83 /* CGGeometry+CustomOpaqueLoggable.swift */,
 				5E27566F1FC51FCB00B69C83 /* CGColor+OpaquePlaygroundLoggable.swift */,
 				5E2756711FC51FF400B69C83 /* CGImage+CustomOpaqueLoggable.swift */,
+				5EE3867320352F3200D625F0 /* CGFloat+CustomOpaqueLoggable.swift */,
 			);
 			path = CoreGraphics;
 			sourceTree = "<group>";
@@ -544,6 +547,7 @@
 			buildActionMask = 2147483647;
 			files = (
 				5E2756321FC48FD300B69C83 /* NSRange+KeyedArchiveOpaqueRepresentation.swift in Sources */,
+				5EE3867420352F3200D625F0 /* CGFloat+CustomOpaqueLoggable.swift in Sources */,
 				5E27565A1FC4F35300B69C83 /* FloatingPoint+CustomOpaqueLoggable.swift in Sources */,
 				5E2756241FC4886A00B69C83 /* String+TaggedOpaqueRepresentation.swift in Sources */,
 				5E27563D1FC4D17F00B69C83 /* CGColor+KeyedArchiveOpaqueRepresentation.swift in Sources */,

PlaygroundLogger/PlaygroundLogger/CustomLoggable/CoreGraphics/CGFloat+CustomOpaqueLoggable.swift

@@ -0,0 +1,19 @@
+//===--- CGFloat+CustomOpaqueLoggable.swift -------------------------------===//
+//
+// This source file is part of the Swift.org open source project
+//
+// Copyright (c) 2018 Apple Inc. and the Swift project authors
+// Licensed under Apache License v2.0 with Runtime Library Exception
+//
+// See http://swift.org/LICENSE.txt for license information
+// See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
+//
+//===----------------------------------------------------------------------===//
+
+import CoreGraphics
+
+extension CGFloat: CustomOpaqueLoggable {
+    var opaqueRepresentation: LogEntry.OpaqueRepresentation {
+        return self.native
+    }
+}

PlaygroundLogger/PlaygroundLoggerTests/LegacyPlaygroundLoggerTests.swift

@@ -575,6 +575,44 @@ class LegacyPlaygroundLoggerTests: XCTestCase {
     }
 
     // testUInt64EightBytesEncoding(), testNSColorLogging(), and testStructLogging() are excluded, as in their current form they test implementation details of the legacy logger.
+
+    // MARK: - New Tests Using Legacy Infrastructure
+
+    // These are tests which did not exist in the previous test suite, but which use the legacy infrastructure to run.
+    // They should be migrated to new test infrastructure once such a thing exists.
+
+    func testCGFloatLogging() {
+        let cgFloat: CGFloat = 2.0
+        let logdata = legacyLog(instance: cgFloat, name: "cgFloat", id: 0, startLine: 0, endLine: 0, startColumn: 0, endColumn: 0) as! NSData
+        guard let decoded = legacyLogDecode(logdata), let iderepr = decoded.object as? PlaygroundDecodedObject_IDERepr else {
+            XCTFail("Decoded object is not IDERepr")
+            return
+        }
+
+        XCTAssertEqual(iderepr.name, "cgFloat")
+        XCTAssertEqual(iderepr.typeName, "CoreGraphics.CGFloat")
+        XCTAssertEqual(iderepr.summary, "2.0")
+
+        if CGFloat.NativeType.self == Double.self {
+            XCTAssertEqual(iderepr.tag, "DOBL")
+            guard iderepr.payload is Double else {
+                XCTFail("Expected a Double as payload but did not have one")
+                return
+            }
+            XCTAssertEqual(iderepr.payload as! Double, 2.0 as Double)
+        }
+        else if CGFloat.NativeType.self == Float.self {
+            XCTAssertEqual(iderepr.tag, "FLOT")
+            guard iderepr.payload is Float else {
+                XCTFail("Expected a Float as payload but did not have one")
+                return
+            }
+            XCTAssertEqual(iderepr.payload as! Float, 2.0 as Float)
+        }
+        else {
+            XCTFail("Unknown CGFloat.NativeType: \(CGFloat.NativeType.self)")
+        }
+    }
 }
 
 // generic so can't be nested in the test case itself