feat: enhance convertHeaders function and add comprehensive unit tests

- Improve `convertHeaders` function documentation for clarity
- Modify `convertHeaders` function to handle edge cases with empty keys or values
- Replace `strings.Split` with `strings.SplitN` to limit splits to 2 parts in `convertHeaders`
- Add trimming of whitespace for keys and values in `convertHeaders`
- Add new test file `proxy_test.go` with unit tests for `convertHeaders` function

Signed-off-by: appleboy <[email protected]>

Author: appleboy

proxy/proxy.go

@@ -10,18 +10,35 @@ import (
 	"golang.org/x/net/proxy"
 )
 
-// convertHeaders takes a slice of strings representing HTTP headers in the format "key=value"
-// and converts them into an http.Header type. If a header string does not contain exactly one "=",
-// it is ignored. The resulting http.Header map is returned.
+// convertHeaders converts a slice of strings representing HTTP headers
+// into an http.Header map. Each string in the input slice should be in
+// the format "key=value". If a string cannot be split into exactly two
+// parts, or if either the key or value is empty after trimming whitespace,
+// that string is ignored.
+//
+// Parameters:
+//
+//	headers []string - A slice of strings where each string represents an
+//	                   HTTP header in the format "key=value".
+//
+// Returns:
+//
+//	http.Header - A map of HTTP headers where the keys are header names
+//	              and the values are header values.
 func convertHeaders(headers []string) http.Header {
 	h := make(http.Header)
 	for _, header := range headers {
 		// split header into key and value with = as delimiter
-		vals := strings.Split(header, "=")
-		if len(vals) != 2 {
+		parts := strings.SplitN(header, "=", 2)
+		if len(parts) != 2 {
+			continue
+		}
+		key := strings.TrimSpace(parts[0])
+		value := strings.TrimSpace(parts[1])
+		if key == "" || value == "" {
 			continue
 		}
-		h.Add(vals[0], vals[1])
+		h.Add(key, value)
 	}
 	return h
 }

proxy/proxy_test.go

@@ -0,0 +1,43 @@
+package proxy
+
+import (
+	"net/http"
+	"reflect"
+	"testing"
+)
+
+func TestConvertHeaders(t *testing.T) {
+	testCases := []struct {
+		headers  []string
+		expected http.Header
+	}{
+		{
+			headers: []string{"Content-Type=application/json", "Authorization=Bearer token"},
+			expected: http.Header{
+				"Content-Type":  []string{"application/json"},
+				"Authorization": []string{"Bearer token"},
+			},
+		},
+		{
+			headers: []string{"X-Custom-Header=custom_value", "InvalidHeader"},
+			expected: http.Header{
+				"X-Custom-Header": []string{"custom_value"},
+			},
+		},
+		{
+			headers:  []string{"KeyOnly=", "=ValueOnly"},
+			expected: http.Header{},
+		},
+		{
+			headers:  []string{},
+			expected: http.Header{},
+		},
+	}
+
+	for _, tc := range testCases {
+		result := convertHeaders(tc.headers)
+		if !reflect.DeepEqual(result, tc.expected) {
+			t.Errorf("convertHeaders(%v) = %v, expected %v", tc.headers, result, tc.expected)
+		}
+	}
+}