refactor: improve HTTP client configuration and error handling

- Refactor HTTP transport creation to include optional TLS configuration
- Update HTTP client initialization to use the custom transport
- Improve error handling by wrapping errors with `%w` for better context
- Add error handling for invalid proxy URL in OpenAI provider
- Clarify error message for SOCKS5 proxy connection failure in OpenAI provider

Signed-off-by: appleboy <[email protected]>

Author: appleboy

provider/anthropic/anthropic.go

@@ -137,32 +137,28 @@ func New(opts ...Option) (c *Client, err error) {
 	if err := cfg.valid(); err != nil {
 		return nil, err
 	}
-
-	// Create a new HTTP transport.
-	tr := &http.Transport{}
-	if cfg.skipVerify {
-		tr.TLSClientConfig = &tls.Config{InsecureSkipVerify: true} //nolint:gosec
+	// Create a new HTTP transport with optional TLS configuration.
+	tr := &http.Transport{
+		TLSClientConfig: &tls.Config{InsecureSkipVerify: cfg.skipVerify}, //nolint:gosec
 	}
 
 	// Create a new HTTP client with the specified timeout and proxy, if any.
-	httpClient := http.DefaultClient
+	httpClient := &http.Client{Transport: tr}
 
 	if cfg.proxyURL != "" {
 		proxyURL, err := url.Parse(cfg.proxyURL)
 		if err != nil {
-			return nil, fmt.Errorf("can't parse the proxy URL: %s", err)
+			return nil, fmt.Errorf("can't parse the proxy URL: %w", err)
 		}
 		tr.Proxy = http.ProxyURL(proxyURL)
 	} else if cfg.socksURL != "" {
 		dialer, err := proxy.SOCKS5("tcp", cfg.socksURL, nil, proxy.Direct)
 		if err != nil {
-			return nil, fmt.Errorf("can't connect to the proxy: %s", err)
+			return nil, fmt.Errorf("can't connect to the proxy: %w", err)
 		}
 		tr.DialContext = dialer.(proxy.ContextDialer).DialContext
 	}
 
-	httpClient.Transport = tr
-
 	// Create a new client instance with the necessary fields.
 	engine := &Client{
 		client: anthropic.NewClient(

provider/openai/openai.go

@@ -221,24 +221,28 @@ func New(opts ...Option) (*Client, error) {
 		c.BaseURL = cfg.baseURL
 	}
 
-	// Create a new HTTP transport.
-	tr := &http.Transport{}
-	if cfg.skipVerify {
-		tr.TLSClientConfig = &tls.Config{InsecureSkipVerify: true} //nolint:gosec
+	// Create a new HTTP transport with optional TLS configuration.
+	tr := &http.Transport{
+		TLSClientConfig: &tls.Config{InsecureSkipVerify: cfg.skipVerify}, //nolint:gosec
 	}
 
-	// Create a new HTTP client with the specified timeout and proxy, if any.
+	// Create a new HTTP client with the specified timeout.
 	httpClient := &http.Client{
-		Timeout: cfg.timeout,
+		Timeout:   cfg.timeout,
+		Transport: tr,
 	}
 
+	// Configure proxy settings if provided.
 	if cfg.proxyURL != "" {
-		proxyURL, _ := url.Parse(cfg.proxyURL)
+		proxyURL, err := url.Parse(cfg.proxyURL)
+		if err != nil {
+			return nil, fmt.Errorf("invalid proxy URL: %s", err)
+		}
 		tr.Proxy = http.ProxyURL(proxyURL)
 	} else if cfg.socksURL != "" {
 		dialer, err := proxy.SOCKS5("tcp", cfg.socksURL, nil, proxy.Direct)
 		if err != nil {
-			return nil, fmt.Errorf("can't connect to the proxy: %s", err)
+			return nil, fmt.Errorf("can't connect to the SOCKS5 proxy: %s", err)
 		}
 		tr.DialContext = dialer.(proxy.ContextDialer).DialContext
 	}