Skip to content

Commit e75b338

Browse files
committed
Fix device name issue (argument is now -de)
1 parent 23fa13e commit e75b338

File tree

5 files changed

+12
-7
lines changed

5 files changed

+12
-7
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ The tool build in java and requires minimal set of parameters the minimal comman
9898
+ `-mp` - ImageTester will read from and execute tests based on the batch mapper CSV.
9999
+ `-te` - ImageTester will throw an exception if Eyes detects a mismatch or failure. <br>
100100
+ `-mt` - Sets match timeout and retry timeout (default=500). <br>
101-
+ `-dn` - Sets device name for test in dashboard. <br>
101+
+ `-de` - Sets device name for test in dashboard. <br>
102102
+ `-rf` - Only test files which match a specified regular expression. <br>
103103
+ `-ir` - Ignore regions will be applied to all pages. <br>
104104
**Example:** `-rf "Lorem.*"` will only test files that start with "Lorem" (e.g. Lorem1.pdf, Lorem2.pdf) <br>

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
<groupId>com.applitools.imagetester</groupId>
66
<artifactId>ImageTester</artifactId>
7-
<version>3.5.5</version>
7+
<version>3.5.6</version>
88
<packaging>jar</packaging>
99
<properties>
1010
<maven.compiler.source>1.8</maven.compiler.source>

src/main/java/META-INF/MANIFEST.MF

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
Manifest-Version: 1.0
22
Main-Class: com.applitools.imagetester.ImageTester
3-
Implementation-Version: 3.5.5
3+
Implementation-Version: 3.5.6
44

src/main/java/com/applitools/imagetester/ImageTester.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
import com.applitools.imagetester.lib.Utils;
2727

2828
public class ImageTester {
29-
private static final String cur_ver = "3.5.5";
29+
private static final String cur_ver = "3.5.6";
3030

3131
public static void main(String[] args) {
3232

@@ -91,7 +91,7 @@ public static void main(String[] args) {
9191
.imageCut(cmd.getOptionValues("ic"))
9292
.accSettings(accessibilityOptions)
9393
.logHandler(cmd.hasOption("log"))
94-
.deviceName(cmd.getOptionValue("dn", null));
94+
.deviceName(cmd.getOptionValue("de", null));
9595

9696
config.splitSteps = cmd.hasOption("st");
9797
config.logger = logger;
@@ -572,6 +572,12 @@ private static Options getOptions() {
572572
.hasArgs()
573573
.optionalArg(false)
574574
.build());
575+
options.addOption(Option.builder("de")
576+
.longOpt("deviceName")
577+
.desc("Device Name")
578+
.hasArg()
579+
.argName("deviceNameArg")
580+
.build());
575581

576582

577583
EyesUtilitiesConfig.injectOptions(options);

src/main/java/com/applitools/imagetester/lib/EyesFactory.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,9 @@ public String getFullAgentId() {
6060
// setConfiguration() overrides several Eyes instance fields, so configuration
6161
// should be set first
6262
eyes.setConfiguration(
63-
new Configuration()
63+
eyes.getConfiguration()
6464
.setDeviceInfo(this.deviceName)
6565
);
66-
6766
eyes.setApiKey(this.apiKey);
6867
eyes.setAgentId(String.format("ImageTester/%s", version));
6968
eyes.setSaveFailedTests(saveFailed);

0 commit comments

Comments
 (0)