Replace update_target_region in favor to values.target_region

Author: eirenik0

eyes_common/applitools/common/config/configuration.py

@@ -47,11 +47,6 @@ def id_(self, value):
         self.id = value
 
 
-def _to_rectangle(d):
-    # type: (dict) -> RectangleSize
-    return RectangleSize.from_(d)
-
-
 @attr.s
 class Configuration(object):
     DEFAULT_MATCH_TIMEOUT_MS = 2000
@@ -73,7 +68,7 @@ class Configuration(object):
     app_name = attr.ib(default=None)  # type: Optional[Text]
     test_name = attr.ib(default=None)  # type: Optional[Text]
     viewport_size = attr.ib(
-        default=None, converter=attr.converters.optional(_to_rectangle)
+        default=None, converter=attr.converters.optional(RectangleSize.from_)
     )  # type: Optional[RectangleSize]
     session_type = attr.ib(default=SessionType.SEQUENTIAL)  # type: SessionType
     ignore_baseline = attr.ib(default=None)  # type: Optional[bool]

eyes_core/applitools/core/fluent/check_settings.py

@@ -117,10 +117,6 @@ def timeout(self, timeout):
         self.values.timeout = timeout
         return self
 
-    def update_target_region(self, region):
-        # type: (Region)  -> None
-        self.values.target_region = region
-
     def ignore_regions(self, *regions):
         # type: (*REGION_VALUES)  -> CheckSettings
         """ Adds one or more ignore regions. """

eyes_core/applitools/core/fluent/check_target.py

@@ -15,5 +15,5 @@ def window():
     def region(rect):
         # type: (Region) -> CheckSettings
         cs = CheckSettings()
-        cs.update_target_region(rect)
+        cs.values.target_region = rect
         return cs

eyes_images/applitools/images/fluent.py

@@ -44,5 +44,5 @@ def image(image_or_path):
     def region(image_or_path, rect):  # type: ignore
         # type: (Union[Image.Image, Text], Region) -> ImagesCheckSettings
         check_settings = Target.image(image_or_path)
-        check_settings.update_target_region(rect)
+        check_settings.values.target_region = rect
         return check_settings

eyes_selenium/applitools/selenium/fluent/selenium_check_settings.py

@@ -110,7 +110,7 @@ def __attrs_post_init__(self):
     def region(self, region):
         # type: (Union[Region, Text, List, Tuple, WebElement, EyesWebElement]) -> CheckSettings
         if isinstance(region, Region):
-            self.update_target_region(region)
+            self.values.target_region = region
         elif is_list_or_tuple(region):
             by, value = region
             self.values.target_selector = _css_selector_from_(by, value)
@@ -168,7 +168,7 @@ def scroll_root_element(self, element_or_selector):
         if isinstance(element_or_selector, basestring):
             self._set_scroll_root_selector(element_or_selector)
         elif is_webelement(element_or_selector):
-            self._set_scrool_root_element(element_or_selector)
+            self._set_scroll_root_element(element_or_selector)
 
     def _floating_provider_from(self, region, bounds):
         if is_webelement(region):