Allow to set CSS_SELECTOR and XPATH to SeleniumCheckSettings

* Add tests

Author: eirenik0

eyes_selenium/applitools/selenium/fluent/selenium_check_settings.py

@@ -81,12 +81,12 @@ def size_mode(self):
 def _css_selector_from_(by, value):
     if by == By.ID:
         value = "#%s" % value
-    elif by == By.TAG_NAME:
-        value = value
     elif by == By.CLASS_NAME:
         value = ".%s" % value
     elif by == By.NAME:
         value = '[name="%s"]' % value
+    elif by in [By.XPATH, By.CSS_SELECTOR, By.TAG_NAME]:
+        value = value
     else:
         raise TypeError("By {} is not supported".format(by))
     return value
@@ -192,6 +192,8 @@ def is_list_or_tuple(elm):
 
 
 def is_webelement(elm):
-    return isinstance(elm, WebElement) or isinstance(
-        getattr(elm, "_element", None), WebElement
+    return (
+        isinstance(elm, EyesWebElement)
+        or isinstance(elm, WebElement)
+        or isinstance(getattr(elm, "_element", None), WebElement)
     )

tests/unit/eyes_selenium/test_selenium_check_settings.py

@@ -0,0 +1,42 @@
+from mock import MagicMock
+from selenium.webdriver.common.by import By
+from selenium.webdriver.remote.webelement import WebElement as SeleniumWebElement
+from appium.webdriver import WebElement as AppiumWebElement
+
+from applitools.selenium import Region, EyesWebElement
+from applitools.selenium.fluent import SeleniumCheckSettings
+
+
+def test_check_region(driver_mock):
+    region = Region(0, 1, 2, 3)
+    cs = SeleniumCheckSettings().region(region)
+    assert cs.values.target_region == region
+
+    selector_or_xpath = ".cssSelector_or_XPATH"
+    cs = SeleniumCheckSettings().region(selector_or_xpath)
+    assert cs.values.target_selector == selector_or_xpath
+
+    eyes_element = MagicMock(EyesWebElement)
+    cs = SeleniumCheckSettings().region(eyes_element)
+    assert cs.values.target_element == eyes_element
+
+    selenium_element = MagicMock(SeleniumWebElement)
+    cs = SeleniumCheckSettings().region(selenium_element)
+    assert cs.values.target_element == selenium_element
+
+    appium_element = MagicMock(AppiumWebElement)
+    cs = SeleniumCheckSettings().region(appium_element)
+    assert cs.values.target_element == appium_element
+
+    cs = SeleniumCheckSettings().region([By.NAME, "some-name"])
+    assert cs.values.target_selector == '[name="some-name"]'
+    cs = SeleniumCheckSettings().region([By.ID, "ident"])
+    assert cs.values.target_selector == "#ident"
+    cs = SeleniumCheckSettings().region([By.CLASS_NAME, "class_name"])
+    assert cs.values.target_selector == ".class_name"
+    cs = SeleniumCheckSettings().region([By.TAG_NAME, "tag_name"])
+    assert cs.values.target_selector == "tag_name"
+    cs = SeleniumCheckSettings().region([By.CSS_SELECTOR, selector_or_xpath])
+    assert cs.values.target_selector == selector_or_xpath
+    cs = SeleniumCheckSettings().region([By.XPATH, selector_or_xpath])
+    assert cs.values.target_selector == selector_or_xpath