Merge pull request #4 from applitools/update-setuppy-to-run-on-old-version-of-setutools

Make setup.py compatible with old version of setuptools

Author: eirenik0

eyes_core/setup.py

@@ -1,5 +1,6 @@
 import re
 import codecs
+import sys
 from os import path
 
 from setuptools import setup, find_packages
@@ -23,6 +24,19 @@ def get_version(package_name):
     return version
 
 
+install_requires = [
+    'attrs>=18',
+    'Pillow>=5.0.0',
+    'requests>=2.1.0',
+    # uses for check if the mobile platform is used in the test
+    'Appium-Python-Client>=0.31'
+]
+# using this way of defining instead of 'typing>=3.5.2; python_version<="3.4"'
+# for run on old version of setuptools without issues
+if sys.version_info < (3, 5):
+    # typing module was added as builtin in Python 3.5
+    install_requires.append('typing >= 3.5.2')
+
 setup(
     name='eyes_core',
     version=get_version('core'),
@@ -46,12 +60,7 @@ def get_version(package_name):
         "Topic :: Software Development :: Testing"
     ],
     keywords='applitools eyes eyes_core',
-    install_requires=[
-        'attrs>=18',
-        'Pillow>=5.0.0',
-        'requests>=2.1.0',
-        'typing>=3.5.2; python_version<="3.4"',
-    ],
+    install_requires=install_requires,
     package_data={
         '':     ['README.rst', 'LICENSE'],
         'core': ['py.typed'],

eyes_images/setup.py

@@ -1,5 +1,6 @@
 import re
 import codecs
+import sys
 from os import path
 
 from setuptools import setup, find_packages
@@ -23,6 +24,16 @@ def get_version(package_name):
     return version
 
 
+install_requires = [
+    'eyes-core=={}'.format(get_version('images')),
+    'Pillow>=5.0.0',
+]
+# using this way of defining instead of 'typing>=3.5.2; python_version<="3.4"'
+# for run on old version of setuptools without issues
+if sys.version_info < (3, 5):
+    # typing module was added as builtin in Python 3.5
+    install_requires.append('typing >= 3.5.2')
+
 setup(
     name='eyes_images',
     version=get_version('images'),
@@ -46,11 +57,7 @@ def get_version(package_name):
         "Topic :: Software Development :: Testing"
     ],
     keywords='applitools eyes eyes_images',
-    install_requires=[
-        'eyes-core=={}'.format(get_version('images')),
-        'Pillow>=5.0.0',
-        'typing>=3.5.2; python_version<="3.4"',
-    ],
+    install_requires=install_requires,
     package_data={
         '':     ['README.rst', 'LICENSE'],
         'core': ['py.typed'],

eyes_selenium/setup.py

@@ -1,5 +1,6 @@
 import re
 import codecs
+import sys
 from os import path
 
 from setuptools import setup, find_packages
@@ -23,6 +24,18 @@ def get_version(package_name):
     return version
 
 
+install_requires = [
+    'eyes-core=={}'.format(get_version('selenium')),
+    'tinycss2>=0.6.1',
+    'selenium>=2.53.0',
+    'Pillow>=5.0.0',
+]
+# using this way of defining instead of 'typing>=3.5.2; python_version<="3.4"'
+# for run on old version of setuptools without issues
+if sys.version_info < (3, 5):
+    # typing module was added as builtin in Python 3.5
+    install_requires.append('typing >= 3.5.2')
+
 setup(
     name='eyes_selenium',
     version=get_version('selenium'),
@@ -46,13 +59,7 @@ def get_version(package_name):
         "Topic :: Software Development :: Testing"
     ],
     keywords='applitools eyes eyes_selenium',
-    install_requires=[
-        'eyes-core=={}'.format(get_version('selenium')),
-        'tinycss2>=0.6.1',
-        'selenium>=2.53.0',
-        'Pillow>=5.0.0',
-        'typing>=3.5.2; python_version<="3.4"',
-    ],
+    install_requires=install_requires,
     package_data={
         '':              ['README.rst', 'LICENSE'],
         'eyes_selenium': ['py.typed'],