add ECB Header / IHT to Extended Header

Author: fklassen

epan/dissectors/packet-appneta.c

@@ -105,6 +105,7 @@ static int hf_appneta_resp_cb_request_reserved1;
 static int hf_appneta_resp_cb_request_reserved2;
 static int hf_appneta_resp_cb_ready_reserved1;
 static int hf_appneta_resp_cb_ready_reserved2;
+static int hf_appneta_resp_ecb_iht;
 static int hf_appneta_resp_ecb_request_padding;
 static int hf_appneta_resp_ecb_request_flags;
 static int hf_appneta_resp_ecb_request_flags_first_seq;
@@ -638,7 +639,7 @@ add_subtree(tvbuff_t *tvb, int *offset, proto_tree *current_tree,
 static int
 dissect_responder_headers_parse(tvbuff_t *tvb, packet_info *pinfo, proto_tree *appneta_resp_tree, int offset, int currentHeader, appneta_pkt_type_t appneta_pkt_type)
 {
-    int      remaining = tvb_captured_length_remaining(tvb, 0);
+    int      remaining = tvb_captured_length_remaining(tvb, offset);
     uint32_t pass      = 0;
 
     while (currentHeader != HDR_LAST && currentHeader < HDR_INVALID) {
@@ -1417,9 +1418,18 @@ dissect_appneta_payload(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, voi
 
             ++offset;
             if (bytes >= ecb_payload_min_size && tvb_captured_length_remaining(tvb, offset) > 0) {
-                int currentHeader = tvb_get_uint8(tvb, offset);
-                /* Get a pointer to our subtree */
-                // appneta_resp_tree = proto_item_add_subtree(ti, ett_appneta_resp);
+                int         currentHeader = tvb_get_uint8(tvb, offset);
+                int         headerLength  = tvb_get_uint8(tvb, offset + 1);
+                proto_tree *current_tree  = data_tree;
+                current_tree              = add_subtree(tvb, &offset, current_tree, currentHeader, headerLength,
+                                     "Enhanced Control Burst Header");
+                iht                    = tvb_get_ntohl(tvb, offset);
+                proto_tree_add_item(current_tree, hf_appneta_resp_ecb_iht, tvb, offset, 4, ENC_NA);
+
+                /* set some text in the info column */
+                col_append_fstr(pinfo->cinfo, COL_INFO, " IHT=%u", iht);
+
+                offset += headerLength - 2;
                 offset = dissect_responder_headers_parse(tvb, pinfo, data_tree, offset, currentHeader, appneta_pkt_type);
                 if (!offset)
                     return 0;
@@ -1584,6 +1594,8 @@ register_appneta_responder(void)
          { "Rate Limit CB Ready - reserved1", "appneta-resp.cb_resp_ratelimit_cb_ready_reserved1", FT_UINT8, BASE_DEC, NULL, 0x0, "", HFILL }                    },
         { &hf_appneta_resp_cb_ready_reserved2,
          { "Rate Limit CB Ready - reserved2", "appneta-resp.cb_resp_ratelimit_cb_ready_reserved2", FT_UINT8, BASE_DEC, NULL, 0x0, "", HFILL }                    },
+        { &hf_appneta_resp_ecb_iht,
+         { "Interrupt Hold Time", "appneta-resp.ecb.iht", FT_UINT32, BASE_DEC, NULL, 0x0, "", HFILL }                                                            },
         { &hf_appneta_resp_ecb_request_padding,
          { "ECB Request padding", "appneta-resp.ecb_request_padding", FT_UINT8, BASE_DEC, NULL, 0x0, "", HFILL }                                                 },
         { &hf_appneta_resp_ecb_request_flags,