Skip to content

Commit 4faf08d

Browse files
committed
Address code comments.
* Update changelog verb. * Unset env var after test. * Fix an unnecessary string formatt
1 parent 464de46 commit 4faf08d

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1313

1414
## [2.2.0] - 2025-06-12
1515

16-
### Improved
16+
### Added
1717

1818
* apppack.toml file is now accessible by APPPACK_TOML environment variable, allowing different services in different environments.

builder/build/prebuild.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ func (b *Build) ConvertAppJson() error {
155155
}
156156
if appJsonExists && !apppackTomlExists {
157157
// convert app.json to apppack.toml
158-
b.Log().Info().Msg(fmt.Sprintf("Converting %s to %s", "app.json", filename))
158+
b.Log().Info().Msg(fmt.Sprintf("Converting app.json to %s", filename))
159159
t := b.AppJSON.ToApppackToml()
160160
return b.state.WriteTomlToFile(filename, t)
161161
}

builder/filesystem/filesystem_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ func TestGetFilename(t *testing.T) {
123123

124124
// Set the env variable and check again
125125
os.Setenv("APPPACK_TOML", "custom.toml")
126+
defer os.Unsetenv("APPPACK_TOML") // Clean up after the test
126127
filename = GetAppPackTomlFilename()
127128
if filename != "custom.toml" {
128129
t.Errorf("expected custom.toml, got %s", filename)

0 commit comments

Comments
 (0)