Skip to content

Commit 91043c3

Browse files
fix(region/destory): Ignore error when dockerhub token not present
1 parent 34d47bc commit 91043c3

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [4.6.5] - 2025-03-06
9+
10+
### Fixed
11+
12+
* Properly ignore errors on region deletion if the legacy `dockerhub-access-token` is not found.
13+
814
## [4.6.4] - 2025-03-05
915

1016
### Removed

stacks/region.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ func (*RegionStack) PostDelete(sess *session.Session, _ *string) error {
6161
Name: aws.String("/apppack/account/dockerhub-access-token"),
6262
})
6363
// Ignore error if the parameter doesn't exist
64-
if err != nil && !strings.Contains(err.Error(), "ParameterNotFound") {
64+
if err != nil && strings.Contains(err.Error(), "ParameterNotFound") {
6565
logrus.WithError(err).Debug("dockerhub-access-token parameter does not exist")
6666
return nil
6767
}

0 commit comments

Comments
 (0)